RESOLVED FIXED 164321
[CSS Parser] Support scroll-snap-* properties 
https://bugs.webkit.org/show_bug.cgi?id=164321
Summary [CSS Parser] Support scroll-snap-* properties
Dave Hyatt
Reported 2016-11-02 08:49:00 PDT
[CSS Parser] Support scroll-snap-* properties
Attachments
Patch (11.51 KB, patch)
2016-11-02 08:50 PDT, Dave Hyatt 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2016-11-02 08:50:56 PDT
Created attachment 293662 [details] Patch
Simon Fraser (smfr)
Comment 2 2016-11-02 09:00:56 PDT
Comment on attachment 293662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293662&action=review > Source/WebCore/css/parser/CSSPropertyParser.cpp:2009 > static RefPtr<CSSValueList> consumePositionList(CSSParserTokenRange& range, CSSParserMode cssParserMode) Would be nice if this function had "snappoint" in the name somewhere. > Source/WebCore/css/parser/CSSPropertyParser.cpp:2055 > + RefPtr<CSSFunctionValue> result = CSSFunctionValue::create(CSSValueRepeat); darin would say to use auto. Doesn't CSSFunctionValue::create return a Ref<>?
Dave Hyatt
Comment 3 2016-11-02 11:10:56 PDT
Fixed in r208291.
Note You need to log in before you can comment on or make changes to this bug.