Bug 164321 - [CSS Parser] Support scroll-snap-* properties
Summary: [CSS Parser] Support scroll-snap-* properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-02 08:49 PDT by Dave Hyatt
Modified: 2016-11-02 11:10 PDT (History)
0 users

See Also:

Attachments
Patch (11.51 KB, patch)
2016-11-02 08:50 PDT, Dave Hyatt 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2016-11-02 08:49:00 PDT 
[CSS Parser] Support scroll-snap-* properties
Comment 1 Dave Hyatt 2016-11-02 08:50:56 PDT 
Created attachment 293662 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-11-02 09:00:56 PDT 
Comment on attachment 293662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293662&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:2009
>  static RefPtr<CSSValueList> consumePositionList(CSSParserTokenRange& range, CSSParserMode cssParserMode)

Would be nice if this function had "snappoint" in the name somewhere.

> Source/WebCore/css/parser/CSSPropertyParser.cpp:2055
> +                RefPtr<CSSFunctionValue> result = CSSFunctionValue::create(CSSValueRepeat);

darin would say to use auto. Doesn't CSSFunctionValue::create return a Ref<>?
Comment 3 Dave Hyatt 2016-11-02 11:10:56 PDT 
Fixed in r208291.