Bug 164315 - [GTK] Remove FileSystem::filenameToString() and use FileSystem::stringFromFileSystemRepresentation() everywhere instead
Summary: [GTK] Remove FileSystem::filenameToString() and use FileSystem::stringFromFil...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2016-11-02 03:16 PDT by Carlos Garcia Campos
Modified: 2016-11-02 06:05 PDT (History)
6 users (show)

See Also:

Attachments
Patch (17.53 KB, patch)
2016-11-02 03:17 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-11-02 03:16:21 PDT 
Both methods are the same, but FileSystem::filenameToString()  is only defined by GTK and used everywhere. We should use the other one instead and remove FileSystem::filenameToString().
Comment 1 Carlos Garcia Campos 2016-11-02 03:17:48 PDT 
Created attachment 293652 [details]
Patch
Comment 2 WebKit Commit Bot 2016-11-02 03:19:42 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Michael Catanzaro 2016-11-02 05:37:05 PDT 
Comment on attachment 293652 [details]
Patch

I guess this is fine. I suspect the purpose of using the different name was to indicate that GLib doesn't support filenames with embedded NUL characters, but whatever.
Comment 4 Carlos Garcia Campos 2016-11-02 06:05:33 PDT 
Committed r208278: <http://trac.webkit.org/changeset/208278>