Bug 164313 - Remove RenderMathMLOperator::shouldAllowStretching
Summary: Remove RenderMathMLOperator::shouldAllowStretching
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-02 02:24 PDT by Frédéric Wang (:fredw)
Modified: 2016-11-12 04:44 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.32 KB, patch)
2016-11-06 05:29 PST, Frédéric Wang (:fredw)
darin: review+
Details | Formatted Diff | Diff
Patch (4.56 KB, patch)
2016-11-10 04:02 PST, Frédéric Wang (:fredw)
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (deleted)
2016-11-10 06:12 PST, Build Bot
no flags Details
Patch (4.56 KB, patch)
2016-11-10 13:36 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2016-11-02 02:24:15 PDT
This is a legacy function from the old MathML code. Now that we support large operator in displaystyle, the name is confusing since it is not just vertical/horizontal "stretchy" operators any more. I believe that now we can just expand it inside RenderMathMLOperator::updateMathOperator() by doing something like:

if (isStretchy())
    type = isVertical() ? MathOperator::Type::VerticalOperator : MathOperator::Type::HorizontalOperator;
else if (textContent() && isLargeOperatorInDisplayStyle())
    type = MathOperator::Type::DisplayOperator;
else  
    type = MathOperator::Type::NormalOperator;

and then the condition in RenderMathMLOperator::useMathOperator() will just become

m_mathOperator.type() != MathOperator::Type::NormalOperator || textContent() == minusSign

where we add the accessor MathOperator::type() { return m_operatorType; }
Comment 1 Frédéric Wang (:fredw) 2016-11-06 05:29:28 PST
Created attachment 294021 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2016-11-10 04:02:22 PST
Created attachment 294359 [details]
Patch
Comment 3 Build Bot 2016-11-10 06:12:18 PST
Comment on attachment 294359 [details]
Patch

Attachment 294359 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2489144

New failing tests:
compositing/absolute-inside-out-of-view-fixed.html
Comment 4 Build Bot 2016-11-10 06:12:21 PST
Created attachment 294367 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 5 Frédéric Wang (:fredw) 2016-11-10 13:36:30 PST
Created attachment 294407 [details]
Patch
Comment 6 WebKit Commit Bot 2016-11-12 04:44:43 PST
Comment on attachment 294407 [details]
Patch

Clearing flags on attachment: 294407

Committed r208647: <http://trac.webkit.org/changeset/208647>
Comment 7 WebKit Commit Bot 2016-11-12 04:44:48 PST
All reviewed patches have been landed.  Closing bug.