Bug 164296 – Untangle stylesheet loading state logic

• Status: NEW
• Component: CSS

[Antti Koivisto]

It is too complicated.

[Antti Koivisto]

Created attachment 293603 [details]
patch

[Antti Koivisto]

Created attachment 293607 [details]
patch

[Build Bot]

Comment on attachment 293607 [details]
patch

Attachment 293607 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2446778

New failing tests:
svg/wicd/test-rightsizing-b.xhtml

[Build Bot]

Created attachment 293617 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Antti Koivisto]

Created attachment 293658 [details]
patch

[WebKit Commit Bot]

Attachment 293658 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Created attachment 293695 [details]
patch

[Antti Koivisto]

Created attachment 293698 [details]
patch

[Build Bot]

Comment on attachment 293698 [details]
patch

Attachment 293698 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2452693

New failing tests:
fast/dom/HTMLMeterElement/meter-styles.html
fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
fast/dom/HTMLMeterElement/meter-writing-mode.html
fast/shadow-dom/shadow-style-text-mutation.html
imported/w3c/csswg-test/css-scoping-1/shadow-cascade-order-001.html
fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html

[Build Bot]

Created attachment 293704 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 293698 [details]
patch

Attachment 293698 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2452695

New failing tests:
fast/dom/HTMLMeterElement/meter-styles.html
fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
fast/dom/HTMLMeterElement/meter-writing-mode.html
fast/shadow-dom/shadow-style-text-mutation.html
imported/w3c/csswg-test/css-scoping-1/shadow-cascade-order-001.html
fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html

[Build Bot]

Created attachment 293706 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 293698 [details]
patch

Attachment 293698 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2452716

New failing tests:
fast/dom/HTMLMeterElement/meter-styles.html
fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
fast/dom/HTMLMeterElement/meter-writing-mode.html
fast/shadow-dom/shadow-style-text-mutation.html
fast/dom/HTMLMeterElement/meter-optimums.html
imported/w3c/csswg-test/css-scoping-1/shadow-cascade-order-001.html
fast/dom/HTMLMeterElement/meter-element.html
fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html
fast/dom/HTMLMeterElement/meter-appearances-capacity.html
fast/dom/HTMLMeterElement/meter-boundary-values.html
fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html

[Build Bot]

Created attachment 293709 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 293698 [details]
patch

Attachment 293698 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2452749

New failing tests:
fast/dom/HTMLMeterElement/meter-styles.html
fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
fast/dom/HTMLMeterElement/meter-writing-mode.html
css2.1/t040105-import-01-b.html
fast/shadow-dom/shadow-style-text-mutation.html
fast/block/child-not-removed-from-parent-lineboxes-crash.html
imported/w3c/csswg-test/css-scoping-1/shadow-cascade-order-001.html
fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html

[Build Bot]

Created attachment 293711 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antti Koivisto]

Created attachment 293721 [details]
patch

[Build Bot]

Comment on attachment 293721 [details]
patch

Attachment 293721 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2454121

New failing tests:
css2.1/t040105-import-01-b.html

[Build Bot]

Created attachment 293751 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antti Koivisto]

Created attachment 293761 [details]
patch

[WebKit Commit Bot]

Attachment 293761 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/ProcessingInstruction.cpp:174:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Created attachment 293762 [details]
patch

[Antti Koivisto]

Created attachment 293763 [details]
patch

[Antti Koivisto]

Created attachment 293765 [details]
patch

[Build Bot]

Comment on attachment 293765 [details]
patch

Attachment 293765 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2455615

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 293789 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 293765 [details]
patch

Attachment 293765 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2456006

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 293793 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 293765 [details]
patch

Attachment 293765 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2456087

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 293797 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 293765 [details]
patch

Attachment 293765 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2456635

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 293812 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Brady Eidson]

Comment on attachment 293765 [details]
patch

Patches that have been up for review since 2016 are almost certainly too stale to be relevant to trunk in their current form.

If this patch is still important please rebase it and post it for review again.

[Ahmad Saleem]

@Antti - is this refactoring still valid or needed? Else we can mark this as "RESOLVED LATER" or "RESOLVED WONTFIX" accordingly. Thanks!