Bug 164296 - Untangle stylesheet loading state logic
Summary: Untangle stylesheet loading state logic
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-01 15:17 PDT by Antti Koivisto
Modified: 2018-02-14 10:35 PST (History)
4 users (show)

See Also:


Attachments
patch (19.35 KB, patch)
2016-11-01 15:20 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (20.33 KB, patch)
2016-11-01 15:35 PDT, Antti Koivisto
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.21 MB, application/zip)
2016-11-01 16:38 PDT, Build Bot
no flags Details
patch (29.57 KB, patch)
2016-11-02 07:19 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (32.78 KB, patch)
2016-11-02 14:16 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (32.85 KB, patch)
2016-11-02 14:54 PDT, Antti Koivisto
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-yosemite (1.59 MB, application/zip)
2016-11-02 16:03 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.30 MB, application/zip)
2016-11-02 16:06 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (10.38 MB, application/zip)
2016-11-02 16:20 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (2.03 MB, application/zip)
2016-11-02 16:35 PDT, Build Bot
no flags Details
patch (32.98 KB, patch)
2016-11-02 17:02 PDT, Antti Koivisto
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-yosemite (2.00 MB, application/zip)
2016-11-02 23:50 PDT, Build Bot
no flags Details
patch (36.34 KB, application/octet-stream)
2016-11-03 07:53 PDT, Antti Koivisto
no flags Details
patch (36.35 KB, patch)
2016-11-03 07:55 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (35.62 KB, patch)
2016-11-03 08:05 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (36.26 KB, patch)
2016-11-03 08:59 PDT, Antti Koivisto
beidson: review-
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews113 for mac-yosemite (693.16 KB, application/zip)
2016-11-03 12:32 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews100 for mac-yosemite (653.00 KB, application/zip)
2016-11-03 13:10 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (15.25 MB, application/zip)
2016-11-03 13:41 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (677.02 KB, application/zip)
2016-11-03 15:24 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-11-01 15:17:40 PDT
It is too complicated.
Comment 1 Antti Koivisto 2016-11-01 15:20:42 PDT
Created attachment 293603 [details]
patch
Comment 2 Antti Koivisto 2016-11-01 15:35:07 PDT
Created attachment 293607 [details]
patch
Comment 3 Build Bot 2016-11-01 16:38:39 PDT
Comment on attachment 293607 [details]
patch

Attachment 293607 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2446778

New failing tests:
svg/wicd/test-rightsizing-b.xhtml
Comment 4 Build Bot 2016-11-01 16:38:42 PDT
Created attachment 293617 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 5 Antti Koivisto 2016-11-02 07:19:03 PDT
Created attachment 293658 [details]
patch
Comment 6 WebKit Commit Bot 2016-11-02 07:20:03 PDT
Attachment 293658 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Antti Koivisto 2016-11-02 14:16:23 PDT
Created attachment 293695 [details]
patch
Comment 8 Antti Koivisto 2016-11-02 14:54:32 PDT
Created attachment 293698 [details]
patch
Comment 9 Build Bot 2016-11-02 16:03:33 PDT
Comment on attachment 293698 [details]
patch

Attachment 293698 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2452693

New failing tests:
fast/dom/HTMLMeterElement/meter-styles.html
fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
fast/dom/HTMLMeterElement/meter-writing-mode.html
fast/shadow-dom/shadow-style-text-mutation.html
imported/w3c/csswg-test/css-scoping-1/shadow-cascade-order-001.html
fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html
Comment 10 Build Bot 2016-11-02 16:03:38 PDT
Created attachment 293704 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 11 Build Bot 2016-11-02 16:06:44 PDT
Comment on attachment 293698 [details]
patch

Attachment 293698 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2452695

New failing tests:
fast/dom/HTMLMeterElement/meter-styles.html
fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
fast/dom/HTMLMeterElement/meter-writing-mode.html
fast/shadow-dom/shadow-style-text-mutation.html
imported/w3c/csswg-test/css-scoping-1/shadow-cascade-order-001.html
fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html
Comment 12 Build Bot 2016-11-02 16:06:47 PDT
Created attachment 293706 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 13 Build Bot 2016-11-02 16:20:18 PDT
Comment on attachment 293698 [details]
patch

Attachment 293698 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2452716

New failing tests:
fast/dom/HTMLMeterElement/meter-styles.html
fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
fast/dom/HTMLMeterElement/meter-writing-mode.html
fast/shadow-dom/shadow-style-text-mutation.html
fast/dom/HTMLMeterElement/meter-optimums.html
imported/w3c/csswg-test/css-scoping-1/shadow-cascade-order-001.html
fast/dom/HTMLMeterElement/meter-element.html
fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html
fast/dom/HTMLMeterElement/meter-appearances-capacity.html
fast/dom/HTMLMeterElement/meter-boundary-values.html
fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html
Comment 14 Build Bot 2016-11-02 16:20:21 PDT
Created attachment 293709 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 15 Build Bot 2016-11-02 16:35:05 PDT
Comment on attachment 293698 [details]
patch

Attachment 293698 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2452749

New failing tests:
fast/dom/HTMLMeterElement/meter-styles.html
fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
fast/dom/HTMLMeterElement/meter-writing-mode.html
css2.1/t040105-import-01-b.html
fast/shadow-dom/shadow-style-text-mutation.html
fast/block/child-not-removed-from-parent-lineboxes-crash.html
imported/w3c/csswg-test/css-scoping-1/shadow-cascade-order-001.html
fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html
Comment 16 Build Bot 2016-11-02 16:35:08 PDT
Created attachment 293711 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 17 Antti Koivisto 2016-11-02 17:02:05 PDT
Created attachment 293721 [details]
patch
Comment 18 Build Bot 2016-11-02 23:50:52 PDT
Comment on attachment 293721 [details]
patch

Attachment 293721 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2454121

New failing tests:
css2.1/t040105-import-01-b.html
Comment 19 Build Bot 2016-11-02 23:50:55 PDT
Created attachment 293751 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 20 Antti Koivisto 2016-11-03 07:53:50 PDT
Created attachment 293761 [details]
patch
Comment 21 WebKit Commit Bot 2016-11-03 07:55:11 PDT
Attachment 293761 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/ProcessingInstruction.cpp:174:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 22 Antti Koivisto 2016-11-03 07:55:26 PDT
Created attachment 293762 [details]
patch
Comment 23 Antti Koivisto 2016-11-03 08:05:30 PDT
Created attachment 293763 [details]
patch
Comment 24 Antti Koivisto 2016-11-03 08:59:43 PDT
Created attachment 293765 [details]
patch
Comment 25 Build Bot 2016-11-03 12:32:32 PDT
Comment on attachment 293765 [details]
patch

Attachment 293765 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2455615

Number of test failures exceeded the failure limit.
Comment 26 Build Bot 2016-11-03 12:32:35 PDT
Created attachment 293789 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 27 Build Bot 2016-11-03 13:10:34 PDT
Comment on attachment 293765 [details]
patch

Attachment 293765 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2456006

Number of test failures exceeded the failure limit.
Comment 28 Build Bot 2016-11-03 13:10:37 PDT
Created attachment 293793 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 29 Build Bot 2016-11-03 13:41:38 PDT
Comment on attachment 293765 [details]
patch

Attachment 293765 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2456087

Number of test failures exceeded the failure limit.
Comment 30 Build Bot 2016-11-03 13:41:42 PDT
Created attachment 293797 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 31 Build Bot 2016-11-03 15:24:17 PDT
Comment on attachment 293765 [details]
patch

Attachment 293765 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2456635

Number of test failures exceeded the failure limit.
Comment 32 Build Bot 2016-11-03 15:24:21 PDT
Created attachment 293812 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 33 Brady Eidson 2018-02-14 10:35:39 PST
Comment on attachment 293765 [details]
patch

Patches that have been up for review since 2016 are almost certainly too stale to be relevant to trunk in their current form.

If this patch is still important please rebase it and post it for review again.