Sticky position should not use transformed position to compute sticky offset.

[Robert Flack]

Created attachment 293590 [details]
Demo of sticky position in a transformed container.

A sticky position element in a transformed container should use its untransformed position for the sticky position offset constraint. In the attached test case it should appear to stick 100px down as the transform should effectively be applied on its sticky position (See test case in Firefox or Chrome with --enable-experimental-web-platform-features).

[Simon Fraser (smfr)]

Thanks for the report.

[Radar WebKit Bug Importer]

<rdar://problem/29054773>

[Martin Robinson]

Created attachment 435854 [details]
Patch

[Martin Robinson]

*** Bug 94992 has been marked as a duplicate of this bug. ***

[Martin Robinson]

Created attachment 435958 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 435958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435958&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:493
> +    FloatRect containerRectRelativeToScrollingAncestor = containingBlock->localToContainerQuad(FloatRect(containerContentRect), &enclosingClippingBox, { } /* mode */).boundingBox();

Maybe instead of /* mode */ say /* ignore transforms */

> Source/WebCore/rendering/RenderBoxModelObject.cpp:521
> +    auto stickyBoxRelativeToScrollingAncestor = parent()->localToContainerQuad(FloatRect(stickyBoxRect), &enclosingClippingBox, { } /* mode */).boundingBox();

Ditto.

[Martin Robinson]

Created attachment 436166 [details]
Patch

[Martin Robinson]

(In reply to Simon Fraser (smfr) from comment #6)
> Comment on attachment 435958 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435958&action=review
> 
> > Source/WebCore/rendering/RenderBoxModelObject.cpp:493
> > +    FloatRect containerRectRelativeToScrollingAncestor = containingBlock->localToContainerQuad(FloatRect(containerContentRect), &enclosingClippingBox, { } /* mode */).boundingBox();
> 
> Maybe instead of /* mode */ say /* ignore transforms */
> 
> > Source/WebCore/rendering/RenderBoxModelObject.cpp:521
> > +    auto stickyBoxRelativeToScrollingAncestor = parent()->localToContainerQuad(FloatRect(stickyBoxRect), &enclosingClippingBox, { } /* mode */).boundingBox();
> 
> Ditto.

Thanks for the review! I've made these changes.

[EWS]

Committed r281446 (240829@main): <https://commits.webkit.org/240829@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436166 [details].

[Brent Fulgham]

This change should be present in STP 139, iOS 15.4 Beta, and macOS 12.3 Beta.