Bug 164289 – Remove WebKitCSSFilterValue to make Hyatt happy

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dean Jackson]

Remove WebKitCSSFilterValue to make Hyatt happy

[Dean Jackson]

<rdar://problem/29050973>

[Dean Jackson]

Created attachment 293585 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 293585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293585&action=review

> Source/WebCore/ChangeLog:9
> +        The new CSS parser doesn't want to use WebKitCSSFilterValue. It's non-standard,

"doesn't want to use" -> "should not use". Or say "don't bring WebKitCSSFilterValue over to the new parser".

> Source/WebCore/ChangeLog:15
> +        We did use it in a few places, so it wasn't easy to get rid of. Most of the
> +        built-in filters could be covered by CSSFunctionValue. url() style filters
> +        become CSSPrimitiveValues that are of the URI type.

A bit too much story-telling here.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:930
> +                BasicColorMatrixFilterOperation& colorMatrixOperation = downcast<BasicColorMatrixFilterOperation>(filterOperation);
> +                filterValue = CSSFunctionValue::create(CSSValueGrayscale);
> +                filterValue->append(cssValuePool.createValue(colorMatrixOperation.amount(), CSSPrimitiveValue::CSS_NUMBER));

You could write these all as:

  filterValue = CSSFunctionValue::create(CSSValueGrayscale);
  filterValue->append(cssValuePool.createValue(downcast<BasicColorMatrixFilterOperation>(filterOperation).amount(), CSSPrimitiveValue::CSS_NUMBER));

[Build Bot]

Comment on attachment 293585 [details]
Patch

Attachment 293585 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2446095

New failing tests:
js/dom/global-constructors-attributes.html

[Build Bot]

Created attachment 293600 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Dean Jackson]

Committed r208253: <http://trac.webkit.org/changeset/208253>