Bug 164283 - Web Inspector: Use more references in inspector code
Summary: Web Inspector: Use more references in inspector code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-11-01 12:16 PDT by Joseph Pecoraro
Modified: 2016-11-01 15:07 PDT (History)
15 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (77.84 KB, patch)
2016-11-01 12:18 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (77.78 KB, patch)
2016-11-01 12:20 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-11-01 12:16:06 PDT 
Summary:
Use more references in inspector code

There are plenty of InspectorInstrumentation methods which take a pointer but do not need to.
While going through the list we can make the instrumentation methods more consistent in some ways.
Comment 1 Joseph Pecoraro 2016-11-01 12:18:36 PDT 
Created attachment 293566 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2016-11-01 12:20:04 PDT 
Created attachment 293567 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2016-11-01 14:45:49 PDT 
Comment on attachment 293567 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 293567

Committed r208240: <http://trac.webkit.org/changeset/208240>
Comment 4 WebKit Commit Bot 2016-11-01 14:45:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Joseph Pecoraro 2016-11-01 15:07:37 PDT 
Attempted a build fix:
<https://trac.webkit.org/changeset/208250>