Bug 164273 – [Win] Copy build results to AAS 'Program Files' folder.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Per Arne Vollan]

The preferred location for the binaries is the AAS 'Program Files' folder.

[Per Arne Vollan]

Created attachment 293553 [details]
Patch

[Per Arne Vollan]

<rdar://problem/28878624>

[Brent Fulgham]

Comment on attachment 293553 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293553&action=review

> Source/WTF/WTF.vcxproj/WTF.proj:75
> +    <CreateItem Include="$(ConfigurationBuildDir)\build32\bin32\WTF$(DebugSuffix).pdb">

I'm worried this change prevents us from copying other "pdb" files that might be generated during the build. Are you sure we only need the one file?

> Source/WTF/WTF.vcxproj/WTF.proj:78
> +    <CreateItem Include="$(ConfigurationBuildDir)\build64\bin64\WTF$(DebugSuffix).pdb">

Ditto.

[Per Arne Vollan]

(In reply to comment #3)
> Comment on attachment 293553 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=293553&action=review
> 
> > Source/WTF/WTF.vcxproj/WTF.proj:75
> > +    <CreateItem Include="$(ConfigurationBuildDir)\build32\bin32\WTF$(DebugSuffix).pdb">
> 
> I'm worried this change prevents us from copying other "pdb" files that
> might be generated during the build. Are you sure we only need the one file?
> 
> > Source/WTF/WTF.vcxproj/WTF.proj:78
> > +    <CreateItem Include="$(ConfigurationBuildDir)\build64\bin64\WTF$(DebugSuffix).pdb">
> 
> Ditto.

The WTF project only generates WTF.dll, so I believe we only need the one file. The same goes for the WebKit project. The JavaScriptCore project generates some executables (testapi.exe, etc.) in addition to JavaScriptCore.dll, but this patch only copies JavaScriptCore.dll to the build result folder, so only JavaScriptCore.pdb should be needed. It is my understanding that we don't need to include these extra JSC executables, please correct me if I am wrong.

Thanks for reviewing!

[WebKit Commit Bot]

Comment on attachment 293553 [details]
Patch

Clearing flags on attachment: 293553

Committed r208275: <http://trac.webkit.org/changeset/208275>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.