Bug 164271 - [Modern Media Controls] load all media controller scripts and styles automatically
Summary: [Modern Media Controls] load all media controller scripts and styles automati...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-01 07:11 PDT by Antoine Quint
Modified: 2016-11-01 11:28 PDT (History)
5 users (show)

See Also:

Attachments
Patch (154.77 KB, patch)
2016-11-01 07:13 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-11-01 07:11:56 PDT 
[Modern Media Controls] load all media controller scripts and styles automatically
Comment 1 Antoine Quint 2016-11-01 07:13:38 PDT 
Created attachment 293551 [details]
Patch
Comment 2 Dean Jackson 2016-11-01 11:04:28 PDT 
Comment on attachment 293551 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293551&action=review

> LayoutTests/media/modern-media-controls/resources/media-controls-loader.js:11
> +    request.open("GET", `${modulePath}/js-files`, false);

Does this file exist yet?
Comment 3 Joseph Pecoraro 2016-11-01 11:16:35 PDT 
Comment on attachment 293551 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293551&action=review

>> LayoutTests/media/modern-media-controls/resources/media-controls-loader.js:11
>> +    request.open("GET", `${modulePath}/js-files`, false);
> 
> Does this file exist yet?

It looks like it does!

> LayoutTests/media/modern-media-controls/resources/media-controls-loader.js:15
> +        document.write(`<script type="text/javascript" src="${modulePath}/${jsFile}"></script>`);

Nit: All of the `type="text/javascript"` attributes are unnecessary and could be removed. But at least you are consistent and use them everywhere.
Comment 4 WebKit Commit Bot 2016-11-01 11:28:13 PDT 
Comment on attachment 293551 [details]
Patch

Clearing flags on attachment: 293551

Committed r208226: <http://trac.webkit.org/changeset/208226>
Comment 5 WebKit Commit Bot 2016-11-01 11:28:17 PDT 
All reviewed patches have been landed.  Closing bug.