Bug 164271 – [Modern Media Controls] load all media controller scripts and styles automatically

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

[Modern Media Controls] load all media controller scripts and styles automatically

[Antoine Quint]

Created attachment 293551 [details]
Patch

[Dean Jackson]

Comment on attachment 293551 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293551&action=review

> LayoutTests/media/modern-media-controls/resources/media-controls-loader.js:11
> +    request.open("GET", `${modulePath}/js-files`, false);

Does this file exist yet?

[Joseph Pecoraro]

Comment on attachment 293551 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293551&action=review

>> LayoutTests/media/modern-media-controls/resources/media-controls-loader.js:11
>> +    request.open("GET", `${modulePath}/js-files`, false);
> 
> Does this file exist yet?

It looks like it does!

> LayoutTests/media/modern-media-controls/resources/media-controls-loader.js:15
> +        document.write(`<script type="text/javascript" src="${modulePath}/${jsFile}"></script>`);

Nit: All of the `type="text/javascript"` attributes are unnecessary and could be removed. But at least you are consistent and use them everywhere.

[WebKit Commit Bot]

Comment on attachment 293551 [details]
Patch

Clearing flags on attachment: 293551

Committed r208226: <http://trac.webkit.org/changeset/208226>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.