Bug 164261 – Add basic visual/layout viewport support for fixed position layout

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

First part of visual viewport support: getting the right rectangles for layout.

[Simon Fraser (smfr)]

Created attachment 293517 [details]
Patch

[Dean Jackson]

Comment on attachment 293517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293517&action=review

> Source/WebCore/page/FrameView.cpp:1802
> +    if (visualViewport.y() < layoutViewport.y() || visualViewport.y() < stableLayoutViewportOriginMin.x())

ERROR!!!
you mean stableLayoutViewportOriginMin.y()

> Source/WebCore/page/FrameView.cpp:1837
> +    LOG_WITH_STREAM(Scrolling, stream << "\nFrameView " << this << " updateLayoutViewport()");
> +
> +    LOG_WITH_STREAM(Scrolling, stream << "layoutViewport: " << layoutViewport);

Remove blank.

> Source/WebCore/page/FrameView.cpp:1866
> +    // This isn't visibleContentRect(), because that uses a scaled scroll origin. Confused? Me too.

Me three.

> Source/WebCore/page/FrameView.cpp:1867
> +    FloatRect visibleContentRect = this->visibleContentRect(LegacyIOSDocumentVisibleRect);

I assume that's available on other platforms too?

> Source/WebCore/page/FrameView.cpp:1904
> +    return scrollPositionForFixedPosition(visibleContentRect(), totalContentsSize(), scrollPosition(), scrollOrigin(), frameScaleFactor(), fixedElementsLayoutRelativeToFrame(), scrollBehaviorForFixedElements(), headerHeight(), footerHeight());

The number of arguments here is nuts.

> Source/WebCore/page/FrameView.cpp:2043
> +        IntPoint unscaledScrollOrigin = -unscaledDocumentRect.location();

Do you need the - part here? It confused me because it would flip the x part too. Except you only use this point to make an IntSize, so maybe just call toIntSize(unscaledDocumentRect.location()) directly?

> Source/WebCore/page/Settings.in:280
> +visualViewportEnabled initial=false, setNeedsStyleRecalcInAllFrames=1

Cool. I didn't know you could do this!

> Source/WebCore/platform/Logging.cpp:80
>      WTFInitializeLogChannelStatesFromString(logChannels, logChannelCount, logLevelString().utf8().data());
> +    LogLayout.state = WTFLogChannelOn;
> +    LogScrolling.state = WTFLogChannelOn;

Ooops! Are you trying to annoy everyone?

> Source/WebCore/testing/Internals.cpp:1096
> +    WTFLogAlways("Internals::layoutViewportRect returning %.2f, %.2f, %.2fx%.2f\n",
> +        layoutViewport.x().toFloat(), layoutViewport.y().toFloat(), layoutViewport.width().toFloat(), layoutViewport.height().toFloat());

Oops again.

> LayoutTests/fast/visual-viewport/nonzoomed-rects.html:31
> +            debug('Scrolled to ' + window.scrollX + ', ' + window.scrollY);

Could use `` strings if you felt like it.

[Simon Fraser (smfr)]

Created attachment 293520 [details]
Patch

[Build Bot]

Comment on attachment 293520 [details]
Patch

Attachment 293520 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2418909

New failing tests:
fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html
http/tests/websocket/tests/hybi/binary-type.html

[Build Bot]

Created attachment 293526 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 293520 [details]
Patch

Attachment 293520 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2418921

New failing tests:
fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html
http/tests/websocket/tests/hybi/binary-type.html

[Build Bot]

Created attachment 293527 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 293520 [details]
Patch

Attachment 293520 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2418937

New failing tests:
fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html
http/tests/websocket/tests/hybi/binary-type.html

[Build Bot]

Created attachment 293528 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 293520 [details]
Patch

Attachment 293520 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2418939

New failing tests:
fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html
http/tests/websocket/tests/hybi/binary-type.html
fast/visual-viewport/zoomed-fixed.html

[Build Bot]

Created attachment 293529 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Simon Fraser (smfr)]

https://trac.webkit.org/r208213