NEW 164254
Rename ViewState to ActivityState 
https://bugs.webkit.org/show_bug.cgi?id=164254
Summary Rename ViewState to ActivityState
Gavin Barraclough
Reported 2016-10-31 16:59:56 PDT
We plan to add a couple more flags to ViewState that aren't directly related to the view itself – whether there is an ongoing page load, and whether whether there is audio playback. This will allow viewState (now activityState) to fully drive throttling decisions. Renaming this bitfield accordingly.
Attachments
Fix (115.11 KB, patch)
2016-10-31 17:01 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Fix (114.26 KB, patch)
2016-10-31 17:11 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Fix (116.25 KB, patch)
2016-10-31 17:21 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Fix (116.27 KB, patch)
2016-10-31 17:25 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Fix (116.27 KB, patch)
2016-10-31 17:25 PDT, Gavin Barraclough 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2016-10-31 17:01:46 PDT
Created attachment 293497 [details] Fix
Gavin Barraclough
Comment 2 2016-10-31 17:11:12 PDT
Created attachment 293499 [details] Fix
WebKit Commit Bot
Comment 3 2016-10-31 17:13:44 PDT
Attachment 293499 [details] did not pass style-queue: ERROR: Source/WebCore/page/Page.h:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:87: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/WebPageCreationParameters.h:43: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/FocusController.h:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/Page.cpp:97: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/efl/WebView.cpp:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:76: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/Plugins/PluginView.h:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/WebPage/DrawingArea.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/PageThrottler.h:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:71: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationController.h:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 13 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 4 2016-10-31 17:21:01 PDT
Created attachment 293501 [details] Fix
WebKit Commit Bot
Comment 5 2016-10-31 17:23:38 PDT
Attachment 293501 [details] did not pass style-queue: ERROR: Source/WebCore/page/PageThrottler.h:30: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 6 2016-10-31 17:25:08 PDT
Created attachment 293502 [details] Fix
Gavin Barraclough
Comment 7 2016-10-31 17:25:50 PDT
Created attachment 293503 [details] Fix
Note You need to log in before you can comment on or make changes to this bug.