Bug 164244 - CSS.supports("font-variation-settings", "'wght' 500") erroneously returns false
Summary: CSS.supports("font-variation-settings", "'wght' 500") erroneously returns false
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-31 15:32 PDT by Myles C. Maxfield
Modified: 2016-11-02 23:46 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.41 KB, patch)
2016-10-31 17:53 PDT, Myles C. Maxfield
mcatanzaro: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (10.92 MB, application/zip)
2016-10-31 19:22 PDT, Build Bot
no flags Details
Patch for committing (8.10 KB, patch)
2016-11-02 19:53 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-10-31 15:32:39 PDT
This is because the "if (m_context.variationFontsEnabled)" is false in the CSSPropertyFontVariationSettings block of CSSParser::parseValue().
Comment 1 Myles C. Maxfield 2016-10-31 15:40:56 PDT
The other CSSParserContext() constructor is being called (implicitly because of the CSSParserMode in DOMCSSNamespace::supports())
Comment 2 Myles C. Maxfield 2016-10-31 16:08:54 PDT
This should be fixed by https://bugs.webkit.org/show_bug.cgi?id=164251

*** This bug has been marked as a duplicate of bug 164251 ***
Comment 3 Myles C. Maxfield 2016-10-31 16:14:18 PDT
....which isn't going to happen. Back to "reopened"
Comment 4 Myles C. Maxfield 2016-10-31 17:53:51 PDT
Created attachment 293505 [details]
Patch
Comment 5 Build Bot 2016-10-31 19:22:44 PDT
Comment on attachment 293505 [details]
Patch

Attachment 293505 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2418091

New failing tests:
fast/text/variations/css-supports-runtime-switch.html
Comment 6 Build Bot 2016-10-31 19:22:47 PDT
Created attachment 293516 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 7 Myles C. Maxfield 2016-11-02 19:53:04 PDT
Created attachment 293737 [details]
Patch for committing
Comment 8 WebKit Commit Bot 2016-11-02 20:28:26 PDT
Comment on attachment 293737 [details]
Patch for committing

Clearing flags on attachment: 293737

Committed r208321: <http://trac.webkit.org/changeset/208321>