WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 164242
Enable custom elements by default everywhere
https://bugs.webkit.org/show_bug.cgi?id=164242
Summary
Enable custom elements by default everywhere
Ryosuke Niwa
Reported
2016-10-31 14:57:21 PDT
The feature is done. Enable it everywhere.
Attachments
Patch
(2.74 KB, patch)
2016-10-31 15:00 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Patch
(7.92 KB, patch)
2016-10-31 15:03 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Enable it in CMake builds
(1.69 KB, patch)
2016-10-31 19:53 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2016-10-31 15:00:48 PDT
Created
attachment 293471
[details]
Patch
Ryosuke Niwa
Comment 2
2016-10-31 15:03:44 PDT
Created
attachment 293474
[details]
Patch
Antti Koivisto
Comment 3
2016-10-31 17:07:10 PDT
Comment on
attachment 293474
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=293474&action=review
> Source/WebCore/features.json:558 > - "status": "In Development" > + "status": "Done"
Nice!
WebKit Commit Bot
Comment 4
2016-10-31 17:35:04 PDT
Comment on
attachment 293474
[details]
Patch Clearing flags on attachment: 293474 Committed
r208201
: <
http://trac.webkit.org/changeset/208201
>
WebKit Commit Bot
Comment 5
2016-10-31 17:35:09 PDT
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 6
2016-10-31 18:04:32 PDT
Note that it's still OFF for all CMake ports since you didn't change WebKitFeatures.cmake. Remember that WebKitFeatures.cmake only affects developers, not end users, at least for CMake ports.
Michael Catanzaro
Comment 7
2016-10-31 18:05:01 PDT
(In reply to
comment #6
)
> Remember that WebKitFeatures.cmake only affects > developers, not end users, at least for CMake ports.
I meant FeatureList.pm here. :)
Ryosuke Niwa
Comment 8
2016-10-31 19:49:21 PDT
(In reply to
comment #7
)
> (In reply to
comment #6
) > > Remember that WebKitFeatures.cmake only affects > > developers, not end users, at least for CMake ports. > > I meant FeatureList.pm here. :)
Oh oops, we need to fix that.
Ryosuke Niwa
Comment 9
2016-10-31 19:51:38 PDT
Apparently, I didn't fix cmake builds.
Ryosuke Niwa
Comment 10
2016-10-31 19:53:27 PDT
Created
attachment 293518
[details]
Enable it in CMake builds
Ryosuke Niwa
Comment 11
2016-10-31 23:50:54 PDT
Comment on
attachment 293518
[details]
Enable it in CMake builds Clearing flags on attachment: 293518 Committed
r208217
: <
http://trac.webkit.org/changeset/208217
>
Ryosuke Niwa
Comment 12
2016-10-31 23:51:00 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug