WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
16424
Enable auto-scroll in page by mouse middle click
https://bugs.webkit.org/show_bug.cgi?id=16424
Summary
Enable auto-scroll in page by mouse middle click
Louise
Reported
2007-12-13 11:18:49 PST
Is there a reason for not having this feature? Since Firefox and Opera supports it, seems reasonablt for webkit to have it too. I couldn't find any bug concerning this problem so I'm going to file one myself. Please tell me if this is not an appropriate place to talk about this. thanks.
Attachments
Add the feature without the icon yet
(9.10 KB, patch)
2008-06-19 13:16 PDT
,
Maxime Britto
hyatt
: review-
Details
Formatted Diff
Diff
patch attempt
(26.36 KB, patch)
2008-07-02 18:53 PDT
,
Maxime Britto
no flags
Details
Formatted Diff
Diff
patch
(26.95 KB, patch)
2008-07-03 12:02 PDT
,
Maxime Britto
no flags
Details
Formatted Diff
Diff
new patch
(32.84 KB, patch)
2008-07-08 11:24 PDT
,
Maxime Britto
adele
: review+
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1
2007-12-13 11:23:42 PST
<
rdar://5603777
>
Robert Blaut
Comment 2
2008-02-18 14:01:19 PST
There is no reason to keeping enhancement requests in an unconfirmed state.
Maxime Britto
Comment 3
2008-06-19 13:16:08 PDT
Created
attachment 21848
[details]
Add the feature without the icon yet This patch adds the requested feature. I also need to work on the icon which should be displayed at the original middle click location (and stay still while scrolling) and will be issued in a future patch.
Dave Hyatt
Comment 4
2008-06-19 14:00:42 PDT
Comment on
attachment 21848
[details]
Add the feature without the icon yet This patch contains tabs. Can you re-attach a tab-free version?
Dave Hyatt
Comment 5
2008-06-19 14:12:35 PDT
The pan scroll shouldn't trigger if you can't scroll the clicked area. Firefox pan scrolls only documents, and does not pan scroll overflow:auto sections. This honestly looks like a bug to me. Your code is doing the same thing, but I think overflow:auto sections should pan scroll.... You might want to test what IE does with overflow sections on Windows when it pan scrolls.
Adam Roben (:aroben)
Comment 6
2008-06-19 14:22:23 PDT
Comment on
attachment 21848
[details]
Add the feature without the icon yet + else if (mouseEvent.button() == MiddleButton && !mev.isOverLink()) { + startPanScroll(); + invalidateClick(); + return false; I don't think !mev.isOverLink() is a good enough check here. You probably wouldn't want the pan to occur when you middle-click on a button. In general, we may not want the pan to occur if event.preventDefault() is called. We should test in Firefox and IE to see if calling event.preventDefault() on a middle-click event prevents the pan from occurring. We should match their behavior in this regard.
Maxime Britto
Comment 7
2008-07-02 18:53:14 PDT
Created
attachment 22057
[details]
patch attempt Works only on windows. Icon added.
Maxime Britto
Comment 8
2008-07-03 09:55:49 PDT
Comment on
attachment 22057
[details]
patch attempt I noticed some cosmetic changes so don't review this one, I'm preparing a new one.
Maxime Britto
Comment 9
2008-07-03 12:02:46 PDT
Created
attachment 22068
[details]
patch Made some functional and cosmetic corrections.
Maxime Britto
Comment 10
2008-07-08 11:24:40 PDT
Created
attachment 22159
[details]
new patch This version fix 2 problems I found with the previous one : - It was possible to trigger multiple panScroll on frameset (one on each frame) - It was possible to trigger the panScroll event when the object was not scrollable
Maxime Britto
Comment 11
2008-07-09 17:31:49 PDT
Fixed in
r35083
Robert Blaut
Comment 12
2008-07-09 22:26:18 PDT
Why the patch is not reviewed?
Maxime Britto
Comment 13
2008-07-09 22:33:43 PDT
It has been reviewed by email this afternoon by Adele Peterson. She will mark it reviewed tomorrow on bugzilla I guess.
Adele Peterson
Comment 14
2008-07-10 09:17:58 PDT
Comment on
attachment 22159
[details]
new patch I reviewed this yesterday.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug