164234 – [MediaStream] restrict media capture secure connections

RESOLVED FIXED 164234

[MediaStream] restrict media capture secure connections

https://bugs.webkit.org/show_bug.cgi?id=164234

Summary [MediaStream] restrict media capture secure connections

Eric Carlson

Reported 2016-10-31 12:16:32 PDT

Restrict media capture to secure connections.

Attachments
Proposed patch. (32.47 KB, patch) 2016-10-31 13:03 PDT, Eric Carlson	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-yosemite (931.65 KB, application/zip) 2016-10-31 14:08 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.46 MB, application/zip) 2016-10-31 14:12 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (19.15 MB, application/zip) 2016-10-31 16:01 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews113 for mac-yosemite (2.00 MB, application/zip) 2016-10-31 19:10 PDT, Build Bot	no flags	Details
Updated patch. (32.46 KB, patch) 2016-11-01 07:52 PDT, Eric Carlson	achristensen: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews116 for mac-yosemite (1.73 MB, application/zip) 2016-11-01 11:42 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-yosemite (1.14 MB, application/zip) 2016-11-01 11:56 PDT, Build Bot	no flags	Details
Patch for landing. (32.96 KB, patch) 2016-11-01 13:42 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Patch for landing. (32.97 KB, patch) 2016-11-01 14:36 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Eric Carlson

Comment 1 2016-10-31 12:35:04 PDT

<rdar://problem/28944906>

Eric Carlson

Comment 2 2016-10-31 13:03:07 PDT

Created attachment 293455 [details] Proposed patch.

Build Bot

Comment 3 2016-10-31 14:08:46 PDT

Comment on attachment 293455 [details] Proposed patch. Attachment 293455 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2413730 New failing tests: http/tests/ssl/media-stream/get-user-media-secure-connection.html http/tests/ssl/media-stream/get-user-media-nested.html http/tests/ssl/media-stream/get-user-media-different-host.html

Build Bot

Comment 4 2016-10-31 14:08:49 PDT

Created attachment 293463 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-10-31 14:12:11 PDT

Comment on attachment 293455 [details] Proposed patch. Attachment 293455 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2413760 New failing tests: svg/wicd/test-rightsizing-b.xhtml http/tests/ssl/media-stream/get-user-media-nested.html

Build Bot

Comment 6 2016-10-31 14:12:15 PDT

Created attachment 293465 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-10-31 16:01:39 PDT

Comment on attachment 293455 [details] Proposed patch. Attachment 293455 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2414975 New failing tests: http/tests/ssl/media-stream/get-user-media-nested.html

Build Bot

Comment 8 2016-10-31 16:01:43 PDT

Created attachment 293480 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2016-10-31 19:10:46 PDT

Comment on attachment 293455 [details] Proposed patch. Attachment 293455 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2417973 New failing tests: http/tests/ssl/media-stream/get-user-media-secure-connection.html http/tests/ssl/media-stream/get-user-media-nested.html http/tests/ssl/media-stream/get-user-media-different-host.html

Build Bot

Comment 10 2016-10-31 19:10:51 PDT

Created attachment 293514 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5

Eric Carlson

Comment 11 2016-11-01 07:52:16 PDT

Created attachment 293552 [details] Updated patch.

Alex Christensen

Comment 12 2016-11-01 10:53:01 PDT

Comment on attachment 293552 [details] Updated patch. View in context: https://bugs.webkit.org/attachment.cgi?id=293552&action=review > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:109 > + if (!documentLoader.response().certificateInfo() || documentLoader.response().certificateInfo()->containsNonRootSHA1SignedCertificate()) I find a few other places where we do this check. We ought to give this check a better name. Also, I wonder why a root SHA1 signed certificate is ok, but not a non-root.

Build Bot

Comment 13 2016-11-01 11:42:15 PDT

Comment on attachment 293552 [details] Updated patch. Attachment 293552 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2444868 New failing tests: http/tests/ssl/media-stream/get-user-media-secure-connection.html http/tests/ssl/media-stream/get-user-media-nested.html http/tests/ssl/media-stream/get-user-media-different-host.html

Build Bot

Comment 14 2016-11-01 11:42:18 PDT

Created attachment 293559 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 15 2016-11-01 11:56:14 PDT

Comment on attachment 293552 [details] Updated patch. Attachment 293552 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2444963 New failing tests: http/tests/ssl/media-stream/get-user-media-secure-connection.html http/tests/ssl/media-stream/get-user-media-nested.html http/tests/ssl/media-stream/get-user-media-different-host.html

Build Bot

Comment 16 2016-11-01 11:56:18 PDT

Created attachment 293562 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Eric Carlson

Comment 17 2016-11-01 13:42:10 PDT

Created attachment 293584 [details] Patch for landing.

Eric Carlson

Comment 18 2016-11-01 14:36:59 PDT

Created attachment 293597 [details] Patch for landing.

WebKit Commit Bot

Comment 19 2016-11-01 15:03:20 PDT

Comment on attachment 293597 [details] Patch for landing. Clearing flags on attachment: 293597 Committed r208249: <http://trac.webkit.org/changeset/208249>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version Other

Hardware Unspecified

OS Unspecified

Product WebKit

Component Media

Assignee

Eric Carlson

Reported

2016-10-31 12:16 PDT

Modified

2017-01-12 09:23 PST History

CC List

7 users Show

URL

Keywords InRadar

Depends on

Blocks