Bug 164230 - LayoutTests/fast/frames/invalid-frameset.html is not clean by the end of FrameView::layout().
Summary: LayoutTests/fast/frames/invalid-frameset.html is not clean by the end of Fram...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks: 162830
  Show dependency tree / graph
 
Reported: 2016-10-31 10:49 PDT by zalan
Modified: 2016-10-31 13:21 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.75 KB, patch)
2016-10-31 10:59 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (1.78 KB, patch)
2016-10-31 11:17 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-10-31 10:49:19 PDT 
All renderers in the render tree should be clean when we finished with FrameView::layout()
Comment 1 zalan 2016-10-31 10:59:18 PDT 
Created attachment 293437 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-10-31 11:01:14 PDT 
Comment on attachment 293437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293437&action=review

> Source/WebCore/ChangeLog:8
> +        This patch clears the needs layout bit on the descendants of the invalid framesets too (and not only the invalid frameset).

This could be clearer about "all descendants, not just children".
Comment 3 zalan 2016-10-31 11:17:46 PDT 
Created attachment 293441 [details]
Patch
Comment 4 WebKit Commit Bot 2016-10-31 13:20:58 PDT 
Comment on attachment 293441 [details]
Patch

Clearing flags on attachment: 293441

Committed r208172: <http://trac.webkit.org/changeset/208172>
Comment 5 WebKit Commit Bot 2016-10-31 13:21:02 PDT 
All reviewed patches have been landed.  Closing bug.