Bug 164227 - Debug JSC test microbenchmarks/pure-get-by-id-cse-2.js timing out
Summary: Debug JSC test microbenchmarks/pure-get-by-id-cse-2.js timing out
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-31 09:46 PDT by Ryan Haddad
Modified: 2016-11-15 12:10 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-10-31 09:46:48 PDT 
** The following JSC stress test failures have been introduced:
	microbenchmarks/pure-get-by-id-cse-2.js.dfg-eager
	microbenchmarks/pure-get-by-id-cse-2.js.dfg-eager-no-cjit-validate
	microbenchmarks/pure-get-by-id-cse-2.js.dfg-maximal-flush-validate-no-cjit
	microbenchmarks/pure-get-by-id-cse-2.js.no-cjit-validate-phases
	microbenchmarks/pure-get-by-id-cse-2.js.no-ftl
	microbenchmarks/pure-get-by-id-cse-2.js.no-llint

https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/4409
Comment 1 Saam Barati 2016-10-31 10:06:55 PDT 
Will fix now.
Comment 2 Saam Barati 2016-10-31 10:29:50 PDT 
landed fix in:
https://trac.webkit.org/changeset/208160
Comment 3 Chris Dumez 2016-11-11 08:54:10 PST 
Reverted r208117 and r208160 for reason:

Regressed Speedometer by >1.5%

Committed r208588: <http://trac.webkit.org/changeset/208588>
Comment 4 Alexey Proskuryakov 2016-11-15 12:03:43 PST 
Looks like both revisions got reverted, so this must fixed for good. Is that correct?
Comment 5 Saam Barati 2016-11-15 12:10:22 PST 
(In reply to comment #4)
> Looks like both revisions got reverted, so this must fixed for good. Is that
> correct?

Yeah sounds correct to me. I'm going to try to re-land the patch at some point soon, so I'll make sure to make this test run for less time when I do.