Bug 164216 – RTCOfferAnswerOptions does not need to be refcounted

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

RTCOfferAnswerOptions does not need to be refcounted

[youenn fablet]

Created attachment 293399 [details]
Patch

[youenn fablet]

Created attachment 293402 [details]
Patch

[Darin Adler]

Comment on attachment 293402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293402&action=review

> Source/WebCore/Modules/mediastream/RTCOfferAnswerOptions.h:37
> +struct RTCOfferOptions : public RTCOfferAnswerOptions {

No need for "public" when it’s a struct.

> Source/WebCore/Modules/mediastream/RTCOfferAnswerOptions.h:43
> +struct RTCAnswerOptions : public RTCOfferAnswerOptions {

Ditto.

[youenn fablet]

Created attachment 293403 [details]
Patch

[youenn fablet]

(In reply to comment #3)
> Comment on attachment 293402 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=293402&action=review
> 
> > Source/WebCore/Modules/mediastream/RTCOfferAnswerOptions.h:37
> > +struct RTCOfferOptions : public RTCOfferAnswerOptions {
> 
> No need for "public" when it’s a struct.

Done
> 
> > Source/WebCore/Modules/mediastream/RTCOfferAnswerOptions.h:43
> > +struct RTCAnswerOptions : public RTCOfferAnswerOptions {
> 
> Ditto.

Done

[Build Bot]

Comment on attachment 293403 [details]
Patch

Attachment 293403 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2409986

New failing tests:
media/modern-media-controls/volume-support/volume-support-click.html

[Build Bot]

Created attachment 293407 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[WebKit Commit Bot]

Comment on attachment 293403 [details]
Patch

Clearing flags on attachment: 293403

Committed r208141: <http://trac.webkit.org/changeset/208141>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.