Bug 164214 – Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Darin Adler]

Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>

[Darin Adler]

Created attachment 293396 [details]
Patch

[Darin Adler]

Comment on attachment 293396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293396&action=review

> Source/WebCore/dom/ExceptionOr.h:56
> +    ReturnReferenceType& releaseReturnValue();

At a later date I would like to explore a synonym just named returnValue() or even value() or possibly operator*() either for all cases or for the cases where the return type is a scalar. This could clean up some of the code using ExceptionOr. But for now, I am sticking with the releaseReturnValue() name.

[WebKit Commit Bot]

Attachment 293396 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:288:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocument.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentFragment.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp"
Total errors found: 1 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Created attachment 293401 [details]
Patch

[WebKit Commit Bot]

Attachment 293401 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:288:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocument.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentFragment.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp"
Total errors found: 1 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 293401 [details]
Patch

Clearing flags on attachment: 293401

Committed r208145: <http://trac.webkit.org/changeset/208145>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.