Bug 164214 - Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
Summary: Move ChildNode and ParentNode from ExceptionCode to Exception, add support fo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-30 23:51 PDT by Darin Adler
Modified: 2016-10-31 08:57 PDT (History)
6 users (show)

See Also:

Attachments
Patch (70.76 KB, patch)
2016-10-31 00:04 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (70.86 KB, patch)
2016-10-31 01:03 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2016-10-30 23:51:04 PDT 
Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
Comment 1 Darin Adler 2016-10-31 00:04:51 PDT 
Created attachment 293396 [details]
Patch
Comment 2 Darin Adler 2016-10-31 00:06:38 PDT 
Comment on attachment 293396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293396&action=review

> Source/WebCore/dom/ExceptionOr.h:56
> +    ReturnReferenceType& releaseReturnValue();

At a later date I would like to explore a synonym just named returnValue() or even value() or possibly operator*() either for all cases or for the cases where the return type is a scalar. This could clean up some of the code using ExceptionOr. But for now, I am sticking with the releaseReturnValue() name.
Comment 3 WebKit Commit Bot 2016-10-31 00:06:51 PDT 
Attachment 293396 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:288:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocument.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentFragment.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp"
Total errors found: 1 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Darin Adler 2016-10-31 01:03:22 PDT 
Created attachment 293401 [details]
Patch
Comment 5 WebKit Commit Bot 2016-10-31 01:05:36 PDT 
Attachment 293401 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:288:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocument.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentFragment.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp"
Total errors found: 1 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Commit Bot 2016-10-31 08:57:47 PDT 
Comment on attachment 293401 [details]
Patch

Clearing flags on attachment: 293401

Committed r208145: <http://trac.webkit.org/changeset/208145>
Comment 7 WebKit Commit Bot 2016-10-31 08:57:52 PDT 
All reviewed patches have been landed.  Closing bug.