Bug 164213 - Remove Battery Status API from the tree
Summary: Remove Battery Status API from the tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-30 20:26 PDT by Brady Eidson
Modified: 2016-11-02 14:32 PDT (History)
8 users (show)

See Also:


Attachments
Patch (220.26 KB, patch)
2016-10-31 10:56 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
patch (284.72 KB, patch)
2016-10-31 11:15 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
patch (157.29 KB, patch)
2016-10-31 11:22 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-10-30 20:26:20 PDT
Remove Battery Status API from the tree

Because it's a privacy (tracking and fingerprinting) risk (https://blog.lukaszolejnik.com/battery-status-readout-as-a-privacy-risk/) Apple never enabled it on their ports.

Mozilla tried to fix it (https://bugzilla.mozilla.org/show_bug.cgi?id=1124127), and then Mozilla decided it wasn't worth keeping around for web content (https://bugzilla.mozilla.org/show_bug.cgi?id=1313580)

The Linux port maintainers don't see a reason to keep it around, as discussed in this thread - https://lists.webkit.org/pipermail/webkit-dev/2016-October/028468.html

I'll use this bug to remove it in a few days as long as the thread continues to have no objections.
Comment 1 Alex Christensen 2016-10-31 10:56:31 PDT
Created attachment 293436 [details]
Patch
Comment 2 Alex Christensen 2016-10-31 11:15:00 PDT
Created attachment 293440 [details]
patch
Comment 3 Alex Christensen 2016-10-31 11:22:34 PDT
Created attachment 293442 [details]
patch
Comment 4 WebKit Commit Bot 2016-10-31 11:25:00 PDT
Attachment 293442 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brady Eidson 2016-10-31 17:02:10 PDT
We should wait a few days to do this to give people a fair chance to voice objections.

There's no rush.
Comment 6 Sam Weinig 2016-11-02 14:30:27 PDT
rs=me
Comment 7 Alex Christensen 2016-11-02 14:32:53 PDT
http://trac.webkit.org/changeset/208300