Bug 164212 - Convert Document from ExceptionCode to Exception
Summary: Convert Document from ExceptionCode to Exception
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-30 17:07 PDT by Darin Adler
Modified: 2016-10-31 08:52 PDT (History)
6 users (show)

See Also:

Attachments
Patch (79.05 KB, patch)
2016-10-30 17:23 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (81.50 KB, patch)
2016-10-30 17:48 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (81.75 KB, patch)
2016-10-30 17:58 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews113 for mac-yosemite (1.35 MB, application/zip)
2016-10-30 18:45 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews101 for mac-yosemite (335.51 KB, application/zip)
2016-10-30 18:48 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (462.36 KB, application/zip)
2016-10-30 18:50 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (517.50 KB, application/zip)
2016-10-30 19:04 PDT, Build Bot 		no flags Details
Patch (84.02 KB, patch)
2016-10-30 21:14 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2016-10-30 17:07:00 PDT 
Convert Document from ExceptionCode to Exception
Comment 1 Darin Adler 2016-10-30 17:23:35 PDT 
Created attachment 293375 [details]
Patch
Comment 2 Darin Adler 2016-10-30 17:48:05 PDT 
Created attachment 293377 [details]
Patch
Comment 3 Darin Adler 2016-10-30 17:58:27 PDT 
Created attachment 293378 [details]
Patch
Comment 4 Build Bot 2016-10-30 18:45:46 PDT 
Comment on attachment 293378 [details]
Patch

Attachment 293378 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2408087

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2016-10-30 18:45:49 PDT 
Created attachment 293380 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-10-30 18:48:35 PDT 
Comment on attachment 293378 [details]
Patch

Attachment 293378 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2408118

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2016-10-30 18:48:38 PDT 
Created attachment 293381 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-10-30 18:50:15 PDT 
Comment on attachment 293378 [details]
Patch

Attachment 293378 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2408117

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2016-10-30 18:50:19 PDT 
Created attachment 293382 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 10 Build Bot 2016-10-30 19:04:38 PDT 
Comment on attachment 293378 [details]
Patch

Attachment 293378 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2408130

Number of test failures exceeded the failure limit.
Comment 11 Build Bot 2016-10-30 19:04:42 PDT 
Created attachment 293383 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 12 Darin Adler 2016-10-30 21:14:09 PDT 
Created attachment 293386 [details]
Patch
Comment 13 Darin Adler 2016-10-30 22:29:13 PDT 
OK, looks like this is now compiling and passing all the tests so ready for review.
Comment 14 WebKit Commit Bot 2016-10-31 08:52:30 PDT 
Comment on attachment 293386 [details]
Patch

Clearing flags on attachment: 293386

Committed r208144: <http://trac.webkit.org/changeset/208144>
Comment 15 WebKit Commit Bot 2016-10-31 08:52:36 PDT 
All reviewed patches have been landed.  Closing bug.