Bug 164210 - [CSS Parser] Fix nth-child serialization
Summary: [CSS Parser] Fix nth-child serialization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-30 15:25 PDT by Dave Hyatt
Modified: 2016-10-30 15:36 PDT (History)
0 users

See Also:

Attachments
Patch (3.18 KB, patch)
2016-10-30 15:29 PDT, Dave Hyatt 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2016-10-30 15:25:43 PDT 
[CSS Parser] Fix nth-child serialization
Comment 1 Dave Hyatt 2016-10-30 15:29:21 PDT 
Created attachment 293371 [details]
Patch
Comment 2 Darin Adler 2016-10-30 15:33:23 PDT 
Comment on attachment 293371 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293371&action=review

I assume all of this gets covered by tests when we turn on the new CSS parser?

> Source/WebCore/css/parser/CSSSelectorParser.cpp:544
> +    const CSSParserToken& argumentStart = block.peek();

Why not auto&?

> Source/WebCore/css/parser/CSSSelectorParser.cpp:565
> +            const CSSParserToken& argumentEnd = block.peek();

Why not auto&?
Comment 3 Dave Hyatt 2016-10-30 15:36:05 PDT 
Landed in r208133.