164199 – [WTF] Import std::optional reference implementation as WTF::Optional

RESOLVED FIXED Bug 164199

[WTF] Import std::optional reference implementation as WTF::Optional

https://bugs.webkit.org/show_bug.cgi?id=164199

Summary [WTF] Import std::optional reference implementation as WTF::Optional

Yusuke Suzuki

Reported 2016-10-29 23:00:04 PDT

WTF::Optional<> uses placement new. It makes this thing non-literal-type, and prevent us from using Optional in constexpr. This means that we cannot use `static const XXX value` global variable where XXX includes Optional<> thingy since we WebKit do not allow global constructors.

Attachments
Patch (150.61 KB, patch) 2016-10-30 21:21 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (150.61 KB, patch) 2016-10-30 21:35 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (150.49 KB, patch) 2016-10-30 21:42 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (150.43 KB, patch) 2016-10-30 21:51 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (155.68 KB, patch) 2016-10-31 01:21 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (155.86 KB, patch) 2016-10-31 01:53 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.53 MB, application/zip) 2016-10-31 03:19 PDT, Build Bot	no flags	Details
Patch (155.72 KB, patch) 2016-10-31 10:55 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (156.31 KB, patch) 2016-10-31 11:59 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.08 MB, patch) 2016-11-02 20:48 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.17 MB, patch) 2016-11-26 16:28 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.17 MB, patch) 2016-11-26 16:45 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch for landing (1.17 MB, patch) 2016-11-26 17:35 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2016-10-29 23:01:06 PDT

Actually, DOMJIT::Effect includes Optional<> thing. If this Optional<> becomes literal type, we can use DOMJIT::Effect in static const variables. And it allows us to generate DOMJIT signatures from IDL easily.

Yusuke Suzuki

Comment 2 2016-10-29 23:01:33 PDT

Note that C++17 std::optional requires that std::optional<literal type> is literal type.

Yusuke Suzuki

Comment 3 2016-10-30 15:34:01 PDT

I have a patch for that, changing the current WTF::Optional to support these features. But given the large change, I wonder if we just include LLVM libc++'s std::experimental::optional. It has complete interface aligned to the C++17 draft. I remember that we import the implementation for std::variant from somewhere.

Yusuke Suzuki

Comment 4 2016-10-30 15:35:14 PDT

(In reply to comment #3) > I have a patch for that, changing the current WTF::Optional to support these > features. > But given the large change, I wonder if we just include LLVM libc++'s > std::experimental::optional. It has complete interface aligned to the C++17 > draft. > I remember that we import the implementation for std::variant from somewhere. I mean that importing the libc++ optional header, rewriting some part of it to adopt it in WTF, and renaming it as WTF::Optional. This is the same way to the WTF::Variant.

Yusuke Suzuki

Comment 5 2016-10-30 15:37:53 PDT

Note that the implementation technique is described in the original std::optional proposal paper. In the case of std::is_trivially_destructible<T>::value = true, we use the union of dummy type and T for the storage. struct Dummy { }; union { Dummy dummy; T value; }; http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3527.html#implementability

JF Bastien

Comment 6 2016-10-30 15:52:45 PDT

You mean importing this: https://github.com/llvm-mirror/libcxx/blob/master/include/experimental/optional ? Assuming importing MIT-licensed code is OK, that sounds like a fine approach since it'll be in C++17. Makes it easy to transition in the future.

Yusuke Suzuki

Comment 7 2016-10-30 15:59:35 PDT

(In reply to comment #6) > You mean importing this: > https://github.com/llvm-mirror/libcxx/blob/master/include/experimental/ > optional > ? > > Assuming importing MIT-licensed code is OK, that sounds like a fine approach > since it'll be in C++17. Makes it easy to transition in the future. Right, with some modification to adopt it in WTF. I remember we already import some of the University of Illinois Open Source Licenses things. https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h#L29-L71

Yusuke Suzuki

Comment 8 2016-10-30 17:37:45 PDT

Interesting. This change figures out that there are some classes deleting move assignment operator but having move constructors. And they use WTF::Optional. It seems that this becomes compile error with C++17 std::optional.

JF Bastien

Comment 9 2016-10-30 17:45:24 PDT

(In reply to comment #8) > Interesting. This change figures out that there are some classes deleting > move assignment operator but having move constructors. And they use > WTF::Optional. It seems that this becomes compile error with C++17 > std::optional. I'm not sure I understand why the code would do this. Is it just misguided?

Darin Adler

Comment 10 2016-10-30 17:51:13 PDT

(In reply to comment #8) > This change figures out that there are some classes deleting > move assignment operator but having move constructors. Which classes?

Yusuke Suzuki

Comment 11 2016-10-30 18:02:16 PDT

(In reply to comment #10) > (In reply to comment #8) > > This change figures out that there are some classes deleting > > move assignment operator but having move constructors. > > Which classes? Oops, no. I misunderstood. Some classes define move constructor, but they do not define move assignment operator. And these classes are noncopyable. They deletes copy assignment operator. At that time, Optional<XXX> value; value = XXX(...); causes compile error. The example is DFG::FPRTemporary, DFG::JSValueOperand, DFG::SpeculateCellOperand. And it seems that DOMPromise is also the thing.

Yusuke Suzuki

Comment 12 2016-10-30 18:03:45 PDT

(In reply to comment #11) > (In reply to comment #10) > > (In reply to comment #8) > > > This change figures out that there are some classes deleting > > > move assignment operator but having move constructors. > > > > Which classes? > > Oops, no. I misunderstood. Some classes define move constructor, but they do > not define move assignment operator. And these classes are noncopyable. They > deletes copy assignment operator. > At that time, > > Optional<XXX> value; > > value = XXX(...); > > causes compile error. > The example is DFG::FPRTemporary, DFG::JSValueOperand, > DFG::SpeculateCellOperand. > And it seems that DOMPromise is also the thing. Ah, it is incorrect for DOMPromise. In DOMPromise, it has move constructor. But it does not have move assignment operator.

Yusuke Suzuki

Comment 13 2016-10-30 18:10:25 PDT

OK, I've found the thing. DOMPromise also has the same issue. DOMPromise has move constructor. But it does not have move assignment operator. It seems that it has copy assignment operator (operator=(DOMPromise const&) = default). But actually it does not. It is ill-formed since the member Ref does not have copy assignment operator. Previously WTF::Optional<>::operator=(WTF::Optional<T>&&) does not use move assignment operator. It always destroy the current content if |this| is engaged. So, the only move constructor is used. But new optional uses move assignment operator in that case.

Yusuke Suzuki

Comment 14 2016-10-30 21:21:47 PDT

Created attachment 293387 [details] Patch

WebKit Commit Bot

Comment 15 2016-10-30 21:24:09 PDT

Attachment 293387 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:423: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WTF/wtf/Optional.h:6: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:7: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:50: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:214: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:217: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:226: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:228: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:228: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:228: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:230: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:230: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WTF/wtf/Optional.h:235: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:243: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:243: _NotVoid is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:245: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:250: __test_swap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:257: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:261: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:265: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:267: Extra space between && and noexcept [whitespace/declaration] [3] ERROR: Source/WTF/wtf/Optional.h:267: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:271: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:276: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:279: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:280: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:280: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:283: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:284: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:291: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:293: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:296: __null_state_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:297: __val_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:299: __engaged_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:309: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:310: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:322: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:323: Wrong number of spaces before statement. (expected: 26) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:330: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:330: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:331: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:332: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:332: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:335: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:335: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:336: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:337: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:337: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:342: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:343: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:343: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:343: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:344: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:344: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:349: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:351: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:354: __null_state_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:355: __val_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:357: __engaged_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:360: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:361: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:373: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:374: Wrong number of spaces before statement. (expected: 26) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:381: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:381: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:382: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:383: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:383: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:386: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:386: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:387: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:388: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:388: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:393: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:394: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:394: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:394: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:395: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:395: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:401: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:402: __base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:404: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:407: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:409: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:411: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:417: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:421: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:423: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:425: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:428: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:429: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:430: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:431: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:432: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:436: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:439: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:440: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:441: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:442: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:443: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:447: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:453: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:465: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:469: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:470: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:483: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:484: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:487: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:491: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:492: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:504: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:505: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:506: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:506: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:507: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:507: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:510: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:518: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:526: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:527: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:528: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:529: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:530: Weird numbe r of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:542: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:543: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:544: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:545: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:546: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:560: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:561: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:563: Use 'using namespace std;' instead of 'using std::swap;'. [build/using_std] [4] ERROR: Source/WTF/wtf/Optional.h:565: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:569: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:570: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:572: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:577: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:578: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:626: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:627: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:628: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:628: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:629: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:630: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:653: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:655: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:657: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:662: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:662: value_or is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:662: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:663: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:665: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:667: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:669: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:788: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:797: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:806: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:815: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:824: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:833: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:842: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:889: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:889: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:898: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:977: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:989: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:990: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:991: result_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:995: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 174 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 16 2016-10-30 21:35:15 PDT

Created attachment 293388 [details] Patch

WebKit Commit Bot

Comment 17 2016-10-30 21:37:34 PDT

Attachment 293388 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:423: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WTF/wtf/Optional.h:6: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:7: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:50: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:214: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:217: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:226: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:228: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:228: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:228: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:230: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:230: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WTF/wtf/Optional.h:235: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:243: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:243: _NotVoid is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:245: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:250: __test_swap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:257: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:261: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:265: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:267: Extra space between && and noexcept [whitespace/declaration] [3] ERROR: Source/WTF/wtf/Optional.h:267: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:271: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:276: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:279: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:280: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:280: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:283: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:284: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:291: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:293: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:296: __null_state_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:297: __val_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:299: __engaged_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:309: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:310: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:322: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:323: Wrong number of spaces before statement. (expected: 26) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:330: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:330: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:331: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:332: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:332: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:335: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:335: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:336: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:337: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:337: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:342: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:343: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:343: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:343: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:344: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:344: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:349: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:351: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:354: __null_state_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:355: __val_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:357: __engaged_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:360: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:361: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:373: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:374: Wrong number of spaces before statement. (expected: 26) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:381: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:381: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:382: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:383: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:383: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:386: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:386: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:387: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:388: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:388: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:393: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:394: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:394: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:394: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:395: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:395: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:401: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:402: __base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:404: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:407: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:409: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:411: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:417: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:421: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:423: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:425: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:428: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:429: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:430: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:431: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:432: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:436: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:439: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:440: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:441: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:442: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:443: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:447: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:453: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:465: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:469: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:470: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:483: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:484: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:487: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:491: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:492: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:504: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:505: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:506: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:506: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:507: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:507: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:510: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:518: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:526: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:527: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:528: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:529: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:530: Weird numbe r of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:542: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:543: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:544: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:545: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:546: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:560: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:561: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:563: Use 'using namespace std;' instead of 'using std::swap;'. [build/using_std] [4] ERROR: Source/WTF/wtf/Optional.h:565: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:569: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:570: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:572: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:577: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:578: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:626: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:627: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:628: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:628: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:629: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:630: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:653: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:655: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:657: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:662: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:662: value_or is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:662: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:663: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:665: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:667: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:669: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:788: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:797: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:806: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:815: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:824: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:833: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:842: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:889: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:889: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:898: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:977: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:989: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:990: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:991: result_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:995: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 174 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 18 2016-10-30 21:42:55 PDT

Created attachment 293389 [details] Patch

WebKit Commit Bot

Comment 19 2016-10-30 21:44:47 PDT

Attachment 293389 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:423: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WTF/wtf/Optional.h:6: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:7: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:50: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:214: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:217: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:226: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:228: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:228: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:228: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:230: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:230: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WTF/wtf/Optional.h:235: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:243: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:243: _NotVoid is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:245: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:250: __test_swap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:257: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:261: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:265: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:267: Extra space between && and noexcept [whitespace/declaration] [3] ERROR: Source/WTF/wtf/Optional.h:267: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:271: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:276: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:279: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:280: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:280: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:283: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:284: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:291: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:293: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:296: __null_state_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:297: __val_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:299: __engaged_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:309: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:310: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:322: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:323: Wrong number of spaces before statement. (expected: 26) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:330: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:330: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:331: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:332: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:332: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:335: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:335: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:336: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:337: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:337: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:342: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:343: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:343: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:343: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:344: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:344: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:349: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:351: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:354: __null_state_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:355: __val_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:357: __engaged_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:360: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:361: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:373: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:374: Wrong number of spaces before statement. (expected: 26) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:381: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:381: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:382: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:383: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:383: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:386: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:386: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:387: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:388: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:388: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:393: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:394: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:394: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:394: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:395: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:395: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:401: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:402: __base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:404: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:407: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:409: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:411: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:417: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:421: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:423: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:425: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:428: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:429: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:430: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:431: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:432: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:436: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:439: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:440: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:441: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:442: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:443: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:447: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:453: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:465: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:469: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:470: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:483: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:484: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:487: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:491: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:492: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:504: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:505: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:506: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:506: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:507: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:507: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:510: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:518: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:526: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:527: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:528: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:529: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:530: Weird numbe r of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:542: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:543: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:544: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:545: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:546: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:560: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:561: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:563: Use 'using namespace std;' instead of 'using std::swap;'. [build/using_std] [4] ERROR: Source/WTF/wtf/Optional.h:565: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:569: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:570: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:572: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:577: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:578: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:648: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:650: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:655: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:655: value_or is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:655: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:656: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:658: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:660: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:662: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:736: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:745: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:754: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:763: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:772: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:781: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:790: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:799: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:808: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:817: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:826: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:835: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:882: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:882: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:891: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:891: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:982: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:983: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:984: result_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:988: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 172 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 20 2016-10-30 21:51:10 PDT

Created attachment 293390 [details] Patch

WebKit Commit Bot

Comment 21 2016-10-30 21:54:13 PDT

Attachment 293390 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:423: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WTF/wtf/Optional.h:6: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:7: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:50: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:214: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:217: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:226: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:228: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:228: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:228: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:230: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:230: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WTF/wtf/Optional.h:235: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:243: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:243: _NotVoid is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:245: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:250: __test_swap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:257: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:261: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:265: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:267: Extra space between && and noexcept [whitespace/declaration] [3] ERROR: Source/WTF/wtf/Optional.h:267: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:271: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:276: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:279: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:280: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:280: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:283: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:284: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:291: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:293: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:296: __null_state_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:297: __val_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:299: __engaged_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:309: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:310: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:322: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:323: Wrong number of spaces before statement. (expected: 26) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:330: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:330: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:331: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:332: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:332: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:335: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:335: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:336: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:337: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:337: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:342: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:343: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:343: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:343: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:344: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:344: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:349: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:351: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:354: __null_state_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:355: __val_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:357: __engaged_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:360: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:361: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:373: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:374: Wrong number of spaces before statement. (expected: 26) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:381: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:381: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:382: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:383: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:383: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:386: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:386: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:387: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:388: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:388: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:393: __optional_storage is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:394: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:394: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WTF/wtf/Optional.h:394: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:395: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:395: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:401: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:402: __base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:404: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:407: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:409: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:411: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:417: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:421: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:423: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:425: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:428: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:429: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:430: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:431: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:432: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:436: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:439: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:440: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:441: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:442: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:443: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:447: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:453: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:465: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:469: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:470: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:483: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:484: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:487: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:491: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:492: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:504: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:505: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:506: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:506: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:507: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:507: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:510: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:518: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:526: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:527: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:528: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:529: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:530: Weird numbe r of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:542: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:543: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:544: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:545: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:546: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:560: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:561: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:563: Use 'using namespace std;' instead of 'using std::swap;'. [build/using_std] [4] ERROR: Source/WTF/wtf/Optional.h:565: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:569: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:570: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:572: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:577: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:578: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:648: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:650: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:655: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:655: value_or is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:655: __v is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:656: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:658: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:660: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:662: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:732: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:741: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:750: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:759: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:768: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:777: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:786: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:795: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:804: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:813: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:822: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:831: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:878: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:878: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:887: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:887: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:978: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:979: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:980: result_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:984: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 172 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 22 2016-10-31 01:21:06 PDT

Created attachment 293404 [details] Patch

WebKit Commit Bot

Comment 23 2016-10-31 01:22:25 PDT

Attachment 293404 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:423: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:154: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:154: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:155: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:174: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:175: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:181: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:183: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:186: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:189: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:195: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:196: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:197: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:199: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:202: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:203: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:206: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:224: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:225: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:229: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:235: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:243: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:248: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:253: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:254: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:255: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:257: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:258: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:260: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:270: static_addressof is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:272: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:283: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:283: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:287: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:292: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:293: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:293: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:293: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:294: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:294: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:294: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:296: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:302: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:302: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:302: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:302: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:302: bad_optional_access is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:302: what_arg is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:303: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:303: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:303: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:303: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:303: bad_optional_access is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:303: what_arg is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:309: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:310: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:310: dummy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:311: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:313: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:313: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:313: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:313: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:313: storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:315: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:316: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:316: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:316: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:316: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:316: storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:318: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:318: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:318: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:324: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:325: dummy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:328: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:328: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:328: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:328: constexpr_storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:331: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:331: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:331: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:331: constexpr_storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:339: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:340: init_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:341: storage_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:343: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:343: optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:345: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:347: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:350: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:353: optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:354: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:356: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:362: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:363: init_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:364: storage_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:366: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:366: constexpr_optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:368: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:370: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:373: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:373: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:377: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:377: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:384: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:393: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:394: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:394: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:394: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:395: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:395: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:395: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:398: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:399: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:400: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:403: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:405: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:405: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:406: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:408: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:408: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:409: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:409: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:409: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:412: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:413: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:413: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:416: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:417: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:419: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:422: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:423: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:427: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:429: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:430: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:431: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:435: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:438: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:440: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:441: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:441: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:442: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:442: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:444: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:445: Wrong number of spaces before statement. (expected: 6) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:445: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:446: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:451: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:453: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:454: Wrong number of spaces before statement. (expected: 6) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:454: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:455: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:457: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:460: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:462: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:462: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:464: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:464: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:466: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:467: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:468: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:468: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:468: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:470: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:472: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:472: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:472: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:475: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:477: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:478: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:479: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:479: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:482: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:484: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:485: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:486: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:486: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:487: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:487: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:488: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:488: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:490: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:492: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:493: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:494: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:495: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:495: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:496: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:496: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:496: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:497: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:497: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:497: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:499: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:501: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:502: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:503: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:504: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:507: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:508: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:509: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:512: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:515: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:516: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:517: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:520: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:522: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:523: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:524: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:527: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:529: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:530: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:531: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:532: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:532: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:532: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:533: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:533: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:533: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:534: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:534: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:535: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:537: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:539: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:541: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:541: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:543: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:547: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:551: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:553: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:555: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:557: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:561: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:563: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:567: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:573: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:579: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:581: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:584: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:585: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:589: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:589: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:590: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:594: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:596: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:598: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:598: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:599: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:601: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:603: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:603: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:607: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:609: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:609: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:619: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:620: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:621: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:621: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:627: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:628: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:628: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:629: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:629: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:631: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:635: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:636: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:636: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:637: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:637: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:639: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:645: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:647: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:649: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:659: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:659: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:659: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:660: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:660: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:660: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:661: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:665: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:666: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:666: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:668: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:668: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:670: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:670: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:672: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:674: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:674: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:676: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:676: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:678: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:680: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:682: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:683: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:686: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:688: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:691: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:693: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:696: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:698: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:699: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:700: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:701: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:704: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:705: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:705: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:708: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:710: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:711: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:712: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:713: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:716: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:717: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:719: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:721: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:723: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:726: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:727: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:727: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:729: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:731: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:732: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:732: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:734: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:736: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:736: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:738: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:740: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:740: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:744: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:746: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:748: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:750: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:751: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:752: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:754: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:760: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:761: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:761: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:761: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:761: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:768: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:768: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:773: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:778: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:783: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:788: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:793: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:799: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:800: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:804: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:805: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:809: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:810: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:814: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:815: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:819: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:820: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:824: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:825: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:829: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:830: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:834: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:835: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:839: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Sour ce/WTF/wtf/Optional.h:840: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:844: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:845: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:849: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:850: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:854: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:855: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:863: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:868: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:873: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:878: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:883: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:888: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:893: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:898: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:903: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:908: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:913: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:918: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:925: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:930: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:935: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:940: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:945: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:950: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:955: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:960: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:965: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:970: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:975: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:980: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:986: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:991: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:996: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1001: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1006: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1011: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1016: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1021: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1026: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1031: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1036: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1041: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1049: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1056: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1062: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1069: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1078: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1079: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1080: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1081: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1081: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1083: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:1085: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1086: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1086: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1086: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1088: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1090: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1091: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1092: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1092: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1094: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:1096: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1097: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1097: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1097: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1099: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 457 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 24 2016-10-31 01:53:20 PDT

Created attachment 293406 [details] Patch

WebKit Commit Bot

Comment 25 2016-10-31 01:57:00 PDT

Attachment 293406 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:423: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/Optional.h:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:156: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:156: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:157: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:176: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:177: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:183: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:188: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:189: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:197: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:198: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:199: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:203: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:205: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:206: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:226: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:227: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:231: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:237: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:245: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:250: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:255: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:256: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:257: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:259: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:260: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:262: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:268: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:272: static_addressof is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:274: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:285: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:285: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:289: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:289: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:294: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:295: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:295: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:295: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:296: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:296: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:296: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:298: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:304: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:304: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:304: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:304: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:304: bad_optional_access is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:304: what_arg is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:305: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:305: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:305: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:305: bad_optional_access is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:305: what_arg is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:311: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:312: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:312: dummy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:313: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:315: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:315: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:315: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:315: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:315: storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:317: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:318: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:318: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:318: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:318: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:318: storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:320: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:320: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:320: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:326: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:327: dummy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:330: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:330: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:330: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:330: constexpr_storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:333: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:333: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:333: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:333: constexpr_storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:341: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:342: init_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:343: storage_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:345: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:345: optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:347: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:349: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:352: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:355: optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:356: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:358: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:364: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:365: init_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:366: storage_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:368: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:368: constexpr_optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:370: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:372: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:375: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:375: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:379: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:379: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:386: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:395: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:396: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:396: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:396: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:397: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:397: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:397: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:400: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:401: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:402: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:405: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:407: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:407: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:408: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:410: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:410: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:411: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:411: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:411: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:414: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:415: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:415: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:418: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:419: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:423: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:424: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:425: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:429: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:431: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:432: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:433: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:437: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:440: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:442: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:443: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:443: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:444: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:444: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:446: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:447: Wrong number of spaces before statement. (expected: 6) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:447: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:448: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:453: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:455: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:456: Wrong number of spaces before statement. (expected: 6) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:456: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:457: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:459: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:462: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:464: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:464: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:466: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:466: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:468: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:469: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:470: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:470: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:470: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:472: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:473: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:474: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:474: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:476: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:477: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:479: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:480: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:481: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:481: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:484: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:487: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:488: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:488: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:489: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:489: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:490: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:490: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:492: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:494: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:495: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:496: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:497: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:497: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:498: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:498: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:498: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:499: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:499: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:499: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:501: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:503: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:504: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:505: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:506: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:510: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:510: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:511: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:514: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:517: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:518: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:519: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:522: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:524: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:525: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:526: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:529: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:531: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:532: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:533: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:534: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:534: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:534: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:535: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:535: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:535: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:536: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:536: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:537: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:539: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:541: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:543: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:543: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:545: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:549: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:553: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:555: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:557: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:559: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:563: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:565: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:571: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:577: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:581: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:583: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:586: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:587: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:591: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:591: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:592: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:596: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:596: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:598: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:600: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:600: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:601: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:603: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:605: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:605: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:609: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:611: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:611: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:615: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:621: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:622: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:623: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:625: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:629: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:630: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:630: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:631: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:631: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:633: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:637: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:638: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:638: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:639: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:639: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:641: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:647: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:648: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:649: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:651: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:661: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:661: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:661: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:662: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:662: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:662: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:663: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:667: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:668: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:668: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:670: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:670: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:672: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:672: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:674: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:676: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:676: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:678: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:678: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:680: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:682: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:684: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:685: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:688: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:690: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:693: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:695: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:698: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:700: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:701: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:702: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:703: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:706: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:707: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:707: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:710: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:712: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:713: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:714: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:715: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:718: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:719: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:721: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:723: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:725: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:728: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:729: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:729: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:731: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:733: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:734: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:734: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:736: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:738: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:738: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:740: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:742: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:742: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:746: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:748: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:750: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:752: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:753: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:754: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:756: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:762: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:763: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:763: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:763: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:763: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:770: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:770: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:775: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:780: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:785: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:790: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:801: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:802: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:806: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:807: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:811: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:812: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:816: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:817: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:821: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:822: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:826: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:827: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:831: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:832: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:836: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:837: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:841: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Sour ce/WTF/wtf/Optional.h:842: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:846: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:847: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:851: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:852: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:856: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:857: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:865: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:870: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:875: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:880: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:885: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:890: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:895: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:900: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:905: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:910: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:915: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:920: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:927: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:932: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:937: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:942: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:947: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:952: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:957: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:962: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:967: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:972: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:977: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:982: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:988: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:993: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:998: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1003: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1008: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1013: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1018: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1023: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1028: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1033: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1038: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1043: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1051: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1058: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1064: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1071: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1080: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1081: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1082: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1083: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1083: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1085: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:1087: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1088: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1088: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1088: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1090: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1092: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1093: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1094: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1094: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1096: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:1098: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1099: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1099: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1099: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 457 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 26 2016-10-31 03:19:50 PDT

Comment on attachment 293406 [details] Patch Attachment 293406 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2410193 New failing tests: fast/mediastream/apply-constraints-audio.html fast/mediastream/apply-constraints-advanced.html fast/mediastream/apply-constraints-video.html

Build Bot

Comment 27 2016-10-31 03:19:53 PDT

Created attachment 293414 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Alex Christensen

Comment 28 2016-10-31 08:06:59 PDT

Comment on attachment 293406 [details] Patch I wanted to overload Optional<bool> to use a 3-state enum instead of two bools to make it so there is only one read operation when using it. Will optimizations like that be possible once we switch to this or c++17? I haven't actually read the generated optimized assembly or measured anything yet

JF Bastien

Comment 29 2016-10-31 08:11:46 PDT

(In reply to comment #28) > Comment on attachment 293406 [details] > Patch > > I wanted to overload Optional<bool> to use a 3-state enum instead of two > bools to make it so there is only one read operation when using it. Will > optimizations like that be possible once we switch to this or c++17? I > haven't actually read the generated optimized assembly or measured anything > yet What you're proposing may be faster (check the assembly, but I assume so). libc++ is unlikely to change its implementation in this manner past C++17 because it would affect ABI. We don't have to care about ABI IIUC, so we can change it as we want. On the other hand, we'd likely want to remove our version once we move to C++17. If the version you have in mind is faster I can help review and commit the change in libc++ (I still have commit access).

Yusuke Suzuki

Comment 30 2016-10-31 10:55:40 PDT

Created attachment 293435 [details] Patch

WebKit Commit Bot

Comment 31 2016-10-31 10:58:30 PDT

Attachment 293435 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:423: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/bindings/js/JSDOMPromise.h:206: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:156: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:156: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:157: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:176: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:177: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:183: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:188: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:189: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:197: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:198: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:199: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:203: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:205: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:206: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:226: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:227: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:231: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:237: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:245: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:250: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:255: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:256: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:257: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:259: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:260: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:262: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:268: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:272: static_addressof is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:274: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:285: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:285: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:289: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:289: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:294: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:295: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:295: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:295: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:296: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:296: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:296: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:298: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:304: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:304: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:304: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:304: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:304: bad_optional_access is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:304: what_arg is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:305: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:305: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:305: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:305: bad_optional_access is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:305: what_arg is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:311: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:312: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:312: dummy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:313: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:315: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:315: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:315: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:315: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:315: storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:317: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:318: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:318: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:318: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:318: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:318: storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:320: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:320: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:320: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:326: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:327: dummy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:330: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:330: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:330: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:330: constexpr_storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:333: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:333: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:333: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:333: constexpr_storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:341: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:342: init_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:343: storage_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:345: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:345: optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:347: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:349: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:352: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:355: optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:356: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:358: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:364: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:365: init_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:366: storage_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:368: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:368: constexpr_optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:370: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:372: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:375: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:375: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:379: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:379: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:386: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:395: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:396: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:396: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:396: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:397: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:397: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:397: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:400: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:401: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:402: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:405: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:407: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:407: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:408: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:410: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:410: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:411: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:411: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:411: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:414: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:415: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:415: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:418: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:419: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:423: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:424: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:425: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:429: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:431: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:432: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:433: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:437: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:440: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:442: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:443: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:443: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:444: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:444: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:446: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:447: Wrong number of spaces before statement. (expected: 6) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:447: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:448: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:453: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:455: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:456: Wrong number of spaces before statement. (expected: 6) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:456: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:457: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:459: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:462: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:464: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:464: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:466: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:466: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:468: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:469: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:470: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:470: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:470: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:472: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:473: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:474: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:474: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:476: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:477: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:479: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:480: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:481: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:481: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:484: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:487: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:488: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:488: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:489: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:489: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:490: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:490: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:492: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:494: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:495: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:496: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:497: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:497: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:498: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:498: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:498: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:499: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:499: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:499: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:501: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:503: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:504: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:505: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:506: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:510: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:510: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:511: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:514: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:517: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:518: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:519: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:522: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:524: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:525: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:526: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:529: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:531: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:532: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:533: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:534: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:534: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:534: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:535: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:535: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:535: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:536: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:536: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:537: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:539: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:541: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:543: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:543: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:545: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:549: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:553: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:555: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:557: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:559: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:563: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:565: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:571: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:577: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:581: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:583: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:586: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:587: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:591: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:591: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:592: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:596: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:596: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:598: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:600: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:600: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:601: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:603: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:605: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:605: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:609: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:611: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:611: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:615: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:621: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:622: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:623: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:625: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:629: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:630: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:630: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:631: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:631: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:633: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:637: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:638: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:638: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:639: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:639: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:641: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:647: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:648: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:649: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:651: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:661: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:661: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:661: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:662: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:662: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:662: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:663: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:667: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:668: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:668: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:670: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:670: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:672: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:672: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:674: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:676: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:676: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:678: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:678: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:680: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:682: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:684: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:685: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:688: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:690: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:693: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:695: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:698: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:700: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:701: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:702: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:703: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:706: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:707: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:707: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:710: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:712: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:713: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:714: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:715: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:718: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:719: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:721: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:723: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:725: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:728: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:729: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:729: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:731: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:733: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:734: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:734: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:736: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:738: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:738: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:740: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:742: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:742: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:746: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:748: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:750: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:752: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:753: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:754: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:756: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:762: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:763: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:763: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:763: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:763: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:770: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:770: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:775: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:780: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:785: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:790: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:801: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:802: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:806: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:807: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:811: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:812: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:816: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:817: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:821: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:822: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:826: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:827: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:831: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:832: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:836: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:837: Weird number of spaces at line-start. Are you using a 4- space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:841: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:842: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:846: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:847: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:851: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:852: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:856: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:857: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:865: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:870: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:875: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:880: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:885: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:890: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:895: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:900: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:905: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:910: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:915: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:920: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:927: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:932: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:937: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:942: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:947: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:952: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:957: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:962: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:967: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:972: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:977: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:982: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:988: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:993: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:998: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1003: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1008: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1013: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1018: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1023: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1028: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1033: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1038: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1043: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1051: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1058: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1064: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1071: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1080: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1081: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1082: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1083: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1083: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1085: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:1087: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1088: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1088: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1088: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1090: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1092: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1093: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1094: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1094: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1096: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:1098: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1099: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1099: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1099: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 458 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 32 2016-10-31 11:01:31 PDT

(In reply to comment #29) > (In reply to comment #28) > > Comment on attachment 293406 [details] > > Patch > > > > I wanted to overload Optional<bool> to use a 3-state enum instead of two > > bools to make it so there is only one read operation when using it. Will > > optimizations like that be possible once we switch to this or c++17? I > > haven't actually read the generated optimized assembly or measured anything > > yet > > What you're proposing may be faster (check the assembly, but I assume so). > libc++ is unlikely to change its implementation in this manner past C++17 > because it would affect ABI. We don't have to care about ABI IIUC, so we can > change it as we want. > > On the other hand, we'd likely want to remove our version once we move to > C++17. If the version you have in mind is faster I can help review and > commit the change in libc++ (I still have commit access). Can we specialize the C++17 std::optional? I mean, is it allowed in the spec? I remember that these attempts are typically undefined, maybe, small part of C++ things are allowed. (like, std::hash, std::swap). Is it correct? And another potentially useful specialization is, Optional<T&>. Having T* internally and use nullptr for Nullopt case.

JF Bastien

Comment 33 2016-10-31 11:15:00 PDT

(In reply to comment #32) > (In reply to comment #29) > > (In reply to comment #28) > > > Comment on attachment 293406 [details] > > > Patch > > > > > > I wanted to overload Optional<bool> to use a 3-state enum instead of two > > > bools to make it so there is only one read operation when using it. Will > > > optimizations like that be possible once we switch to this or c++17? I > > > haven't actually read the generated optimized assembly or measured anything > > > yet > > > > What you're proposing may be faster (check the assembly, but I assume so). > > libc++ is unlikely to change its implementation in this manner past C++17 > > because it would affect ABI. We don't have to care about ABI IIUC, so we can > > change it as we want. > > > > On the other hand, we'd likely want to remove our version once we move to > > C++17. If the version you have in mind is faster I can help review and > > commit the change in libc++ (I still have commit access). > > Can we specialize the C++17 std::optional? > I mean, is it allowed in the spec? > I remember that these attempts are typically undefined, maybe, small part of > C++ things are allowed. (like, std::hash, std::swap). Is it correct? You can but AFAIK it's UB. It means that we'd *need* to #include <wtf/optional.h> and *never* #include <optional>, lest we mess up our internal ABI. Seem fraught with peril when we could fix the implementation before C++17 is finalized. > And another potentially useful specialization is, Optional<T&>. Having T* > internally and use nullptr for Nullopt case. Yeah that could work as well.

Yusuke Suzuki

Comment 34 2016-10-31 11:24:03 PDT

OK, ready for review.

Yusuke Suzuki

Comment 35 2016-10-31 11:59:22 PDT

Created attachment 293447 [details] Patch Slightly update the Optional.h's if-def things to support environment supporting exceptions correctly

WebKit Commit Bot

Comment 36 2016-10-31 12:02:09 PDT

Attachment 293447 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:423: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/bindings/js/JSDOMPromise.h:206: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:163: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:155: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:156: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:175: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:182: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:183: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:186: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:188: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:190: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:196: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:197: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:198: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:200: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:202: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:203: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:204: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:207: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:226: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:227: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:231: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:237: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:245: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:250: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:255: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:256: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:257: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:259: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:260: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:262: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:268: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:272: static_addressof is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:274: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:285: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:285: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:289: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:289: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:294: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:295: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:295: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:295: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:296: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:296: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:296: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:298: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:304: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:304: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:304: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:304: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:304: bad_optional_access is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:304: what_arg is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:305: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:305: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:305: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:305: bad_optional_access is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:305: what_arg is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:311: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:312: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:312: dummy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:313: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:315: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:315: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:315: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:315: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:315: storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:317: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:318: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:318: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:318: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:318: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:318: storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:320: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:320: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:320: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:326: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:327: dummy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:330: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:330: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:330: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:330: constexpr_storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:333: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:333: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:333: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:333: constexpr_storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:341: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:342: init_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:343: storage_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:345: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:345: optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:347: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:349: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:352: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:355: optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:356: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:358: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:364: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:365: init_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:366: storage_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:368: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:368: constexpr_optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:370: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:372: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:375: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:375: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:379: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:379: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:386: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:395: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:396: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:396: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:396: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:397: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:397: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:397: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:400: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:401: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:402: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:405: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:407: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:407: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:408: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:410: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:410: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:411: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:411: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:411: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:414: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:415: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:415: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:418: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:419: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:423: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:424: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:425: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:429: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:431: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:432: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:433: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:437: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:440: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:442: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:443: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:443: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:444: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:444: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:446: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:447: Wrong number of spaces before statement. (expected: 6) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:447: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:448: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:453: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:455: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:456: Wrong number of spaces before statement. (expected: 6) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:456: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:457: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:459: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:462: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:464: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:464: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:466: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:466: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:468: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:469: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:470: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:470: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:470: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:472: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:473: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:474: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:474: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:476: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:477: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:479: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:480: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:481: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:481: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:484: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:487: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:488: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:488: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:489: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:489: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:490: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:490: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:492: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:494: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:495: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:496: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:497: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:497: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:498: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:498: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:498: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:499: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:499: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:499: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:501: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:503: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:504: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:505: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:506: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:510: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:510: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:511: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:514: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:517: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:518: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:519: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:522: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:524: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:525: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:526: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:529: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:531: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:532: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:533: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:534: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:534: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:534: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:535: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:535: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:535: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:536: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:536: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:537: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:539: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:541: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:543: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:543: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:545: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:549: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:553: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:555: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:557: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:559: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:563: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:565: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:571: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:577: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:581: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:583: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:586: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:587: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:591: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:591: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:592: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:596: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:596: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:598: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:600: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:600: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:601: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:603: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:605: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:605: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:609: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:611: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:611: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:615: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:621: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:622: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:623: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:625: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:629: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:630: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:630: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:631: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:631: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:633: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:637: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:638: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:638: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:639: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:639: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:641: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:647: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:648: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:649: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:651: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:661: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:661: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:661: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:662: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:662: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:662: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:663: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:667: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:668: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:668: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:670: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:670: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:672: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:672: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:674: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:676: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:676: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:678: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:678: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:680: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:682: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:684: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:685: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:688: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:690: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:693: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:695: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:698: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:700: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:701: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:702: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:703: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:706: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:707: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:707: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:710: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:712: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:713: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:714: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:715: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:718: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:719: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:721: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:723: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:725: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:728: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:729: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:729: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:731: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:733: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:734: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:734: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:736: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:738: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:738: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:740: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:742: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:742: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:746: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:748: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:750: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:752: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:753: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:754: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:756: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:762: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:763: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:763: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:763: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:763: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:770: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:770: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:775: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:780: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:785: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:790: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:801: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:802: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:806: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:807: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:811: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:812: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:816: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:817: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:821: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:822: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:826: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:827: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:831: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:832: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:836: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:837: Weird number of spaces at line-start. Are you using a 4- space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:841: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:842: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:846: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:847: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:851: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:852: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:856: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:857: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:865: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:870: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:875: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:880: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:885: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:890: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:895: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:900: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:905: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:910: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:915: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:920: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:927: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:932: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:937: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:942: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:947: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:952: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:957: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:962: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:967: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:972: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:977: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:982: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:988: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:993: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:998: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1003: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1008: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1013: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1018: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1023: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1028: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1033: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1038: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1043: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1051: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1058: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1064: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1071: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1080: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1081: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1082: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1083: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1083: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1085: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:1087: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1088: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1088: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1088: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1090: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1092: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1093: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1094: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1094: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1096: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:1098: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1099: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1099: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1099: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 458 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 37 2016-10-31 13:45:11 PDT

Comment on attachment 293447 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293447&action=review > Source/WTF/wtf/Optional.h:1073 > + return *Optional; Oops. I'll use lowercase `optional` here later.

Saam Barati

Comment 38 2016-10-31 15:51:44 PDT

Comment on attachment 293447 [details] Patch This patch seems reasonable to me, however, this implementation feels 10x harder to understand than our implementation (hopefully it's doing important things with that complexity) . It'll be nice when we can remove the implementation entirely. I think it's good to get other folks' opinion on this change, too. Maybe Anders/Darin/Sam have opinions?

Anders Carlsson

Comment 39 2016-11-02 13:29:36 PDT

(In reply to comment #38) > Comment on attachment 293447 [details] > Patch > > This patch seems reasonable to me, however, this implementation feels 10x > harder to understand than our implementation (hopefully it's doing important > things with that complexity) . It'll be nice when we can remove the > implementation entirely. > > I think it's good to get other folks' opinion on this change, too. Maybe > Anders/Darin/Sam have opinions? If this is the same as (the coming) std::optional, maybe we should keep that name. I'm assuming once we can use std::optional we can just drop this one.

Yusuke Suzuki

Comment 40 2016-11-02 14:09:30 PDT

(In reply to comment #39) > (In reply to comment #38) > > Comment on attachment 293447 [details] > > Patch > > > > This patch seems reasonable to me, however, this implementation feels 10x > > harder to understand than our implementation (hopefully it's doing important > > things with that complexity) . It'll be nice when we can remove the > > implementation entirely. > > > > I think it's good to get other folks' opinion on this change, too. Maybe > > Anders/Darin/Sam have opinions? > > If this is the same as (the coming) std::optional, maybe we should keep that > name. I'm assuming once we can use std::optional we can just drop this one. OK, let's make this WTF::Optional to std::optional for a while. When C++17 comes to WebKit, we can just drop this header!

Sam Weinig

Comment 41 2016-11-02 14:18:15 PDT

rs=me with that change.

Yusuke Suzuki

Comment 42 2016-11-02 20:48:08 PDT

Created attachment 293742 [details] Patch

Yusuke Suzuki

Comment 43 2016-11-26 12:44:58 PST

OK, by applying Anders' comment, I'll land it.

Yusuke Suzuki

Comment 44 2016-11-26 16:28:36 PST

Created attachment 295448 [details] Patch Patch for landing

WebKit Commit Bot

Comment 45 2016-11-26 16:32:44 PST

Attachment 295448 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/DataURLDecoder.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.h:168: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.h:348: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentRequest.h:91: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/Optional.h:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:164: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:156: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:157: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:176: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:177: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:183: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:188: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:189: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:197: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:198: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:199: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:203: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:205: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:206: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:228: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:229: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:233: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:239: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:246: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:253: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:254: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:255: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:257: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:258: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:260: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:270: static_addressof is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:272: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:283: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:283: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:287: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:292: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:293: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:293: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:293: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:294: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:294: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:294: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:296: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:302: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:302: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:302: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:302: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:302: bad_optional_access is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:302: what_arg is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:303: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:303: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:303: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:303: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:303: bad_optional_access is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:303: what_arg is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:309: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:310: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:310: dummy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:311: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:313: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:313: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:313: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:313: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:313: storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:315: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:316: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:316: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:316: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:316: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:316: storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:318: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:318: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:318: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:324: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:325: dummy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:328: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:328: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:328: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:328: constexpr_storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:331: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:331: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:331: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:331: constexpr_storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:339: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:340: init_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:341: storage_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:343: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:343: optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:345: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:347: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:350: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:353: optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:354: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:356: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:362: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:363: init_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:364: storage_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:366: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:366: constexpr_optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:368: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:370: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:373: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:373: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:377: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:377: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:384: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:393: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:394: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:394: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:394: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:395: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:395: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:395: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:398: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:399: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:400: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:403: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:405: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:405: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:406: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:408: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:408: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:409: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:409: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:409: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:412: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:413: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:413: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:416: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:417: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:419: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:422: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:423: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:427: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:429: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:430: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:431: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:435: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:438: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:440: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:441: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:441: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:442: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:442: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:444: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:445: Wrong number of spaces before statement. (expected: 6) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:445: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:446: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:451: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:453: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:454: Wrong number of spaces before statement. (expected: 6) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:454: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:455: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:457: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:460: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:462: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:462: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:464: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:464: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:466: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:467: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:468: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:468: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:468: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:470: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:472: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:472: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:472: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:475: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:477: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:478: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:479: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:479: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:482: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:484: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:485: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:486: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:486: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:487: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:487: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:488: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:488: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:490: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:492: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:493: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:494: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:495: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:495: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:496: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:496: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:496: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:497: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:497: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:497: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:499: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:501: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:502: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:503: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:504: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:507: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:508: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:509: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:512: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:515: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:516: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:517: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:520: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:522: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:523: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:524: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:527: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:529: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:530: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:531: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:532: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:532: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:532: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:533: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:533: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:533: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:534: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:534: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:535: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:537: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:539: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:541: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:541: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:543: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:547: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:551: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:553: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:555: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:557: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:561: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:563: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:567: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:573: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:579: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:581: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:584: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:585: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:589: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:589: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:590: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:594: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:596: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:598: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:598: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:599: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:601: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:603: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:603: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:607: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:609: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:609: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:619: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:620: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:621: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:621: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:627: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:628: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:628: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:629: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:629: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:631: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:635: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:636: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:636: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:637: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:637: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:639: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:645: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:647: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:649: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:658: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:659: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:659: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:659: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:660: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:660: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:660: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:661: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:665: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:666: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:666: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:668: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:668: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:670: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:670: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:672: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:674: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:674: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:676: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:676: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:678: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:680: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:682: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:683: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:686: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:688: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:691: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:693: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:696: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:698: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:699: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:700: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:701: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:704: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:705: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:705: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:708: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:710: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:711: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:712: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:713: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:716: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:717: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:719: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:721: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:723: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:726: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:727: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:727: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:729: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:731: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:732: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:732: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:734: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:736: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:736: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:738: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:740: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:740: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:744: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:746: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:748: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:750: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:751: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:752: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:754: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:760: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:761: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:761: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:761: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:761: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:768: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:768: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:773: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:778: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:783: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:788: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:793: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:799: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:800: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:804: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:805: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:809: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:810: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:814: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:815: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:819: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:820: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:824: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:825: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:829: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:830: Weird number of spaces at line-start. Are y ou using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:834: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:835: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:839: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:840: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:844: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:845: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:849: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:850: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:854: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:855: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:863: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:868: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:873: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:878: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:883: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:888: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:893: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:898: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:903: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:908: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:913: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:918: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:925: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:930: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:935: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:940: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:945: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:950: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:955: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:960: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:965: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:970: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:975: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:980: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:986: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:991: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:996: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1001: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1006: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1011: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1016: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1021: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1026: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1031: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1036: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1041: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1049: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1056: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1062: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1082: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1083: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1084: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1085: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1085: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1087: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:1089: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1090: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1090: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1090: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1092: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1094: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1095: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1096: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1096: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1098: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:1100: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1101: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1101: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1103: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:421: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/bindings/js/JSDOMPromise.h:210: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/crypto/JsonWebKey.h:40: key_ops is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h:233: The parameter name "scrollbarStyle" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 463 in 708 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 46 2016-11-26 16:45:55 PST

Created attachment 295450 [details] Patch Patch for landing

WebKit Commit Bot

Comment 47 2016-11-26 17:18:21 PST

Attachment 295450 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/DataURLDecoder.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.h:168: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.h:348: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentRequest.h:91: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/Optional.h:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:164: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:156: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:157: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:176: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:177: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:183: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:188: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:189: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:197: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:198: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:199: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:203: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:205: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:206: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:228: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:229: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:233: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:239: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:246: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:253: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:254: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:255: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:257: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:258: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:260: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:270: static_addressof is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:272: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:283: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:283: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:287: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:292: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:293: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:293: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:293: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:294: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:294: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:294: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:296: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:302: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:302: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:302: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:302: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:302: bad_optional_access is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:302: what_arg is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:303: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:303: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:303: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:303: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:303: bad_optional_access is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:303: what_arg is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:309: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:310: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:310: dummy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:311: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:313: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:313: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:313: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:313: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:313: storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:315: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:316: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:316: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:316: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:316: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:316: storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:318: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:318: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:318: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:324: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:325: dummy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:328: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:328: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:328: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:328: constexpr_storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:331: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:331: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:331: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:331: constexpr_storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:339: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:340: init_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:341: storage_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:343: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:343: optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:345: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:347: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:350: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:353: optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:354: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:356: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:362: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:363: init_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:364: storage_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:366: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:366: constexpr_optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:368: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:370: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:373: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:373: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:377: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:377: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:384: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:393: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:394: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:394: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:394: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:395: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:395: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:395: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:398: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:399: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:400: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:403: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:405: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:405: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:406: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:408: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:408: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:409: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:409: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:409: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:412: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:413: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:413: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:416: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:417: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:419: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:422: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:423: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:427: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:429: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:430: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:431: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:435: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:438: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:440: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:441: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:441: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:442: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:442: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:444: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:445: Wrong number of spaces before statement. (expected: 6) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:445: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:446: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:451: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:453: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:454: Wrong number of spaces before statement. (expected: 6) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:454: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:455: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:457: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:460: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:462: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:462: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:464: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:464: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:466: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:467: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:468: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:468: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:468: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:470: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:472: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:472: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:472: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:475: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:477: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:478: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:479: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:479: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:482: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:484: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:485: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:486: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:486: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:487: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:487: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:488: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:488: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:490: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:492: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:493: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:494: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:495: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:495: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:496: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:496: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:496: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:497: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:497: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:497: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:499: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:501: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:502: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:503: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:504: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:507: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:508: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:509: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:512: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:515: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:516: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:517: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:520: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:522: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:523: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:524: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:527: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:529: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:530: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:531: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:532: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:532: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:532: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:533: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:533: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:533: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:534: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:534: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:535: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:537: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:539: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:541: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:541: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:543: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:547: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:551: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:553: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:555: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:557: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:561: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:563: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:567: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:573: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:579: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:581: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:584: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:585: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:589: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:589: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:590: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:594: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:596: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:598: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:598: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:599: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:601: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:603: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:603: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:607: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:609: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:609: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:619: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:620: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:621: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:621: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:627: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:628: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:628: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:629: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:629: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:631: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:635: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:636: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:636: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:637: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:637: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:639: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:645: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:647: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:649: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:658: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:659: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:659: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:659: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:660: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:660: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:660: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:661: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:665: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:666: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:666: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:668: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:668: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:670: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:670: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:672: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:674: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:674: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:676: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:676: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:678: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:680: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:682: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:683: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:686: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:688: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:691: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:693: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:696: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:698: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:699: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:700: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:701: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:704: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:705: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:705: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:708: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:710: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:711: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:712: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:713: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:716: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:717: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:719: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:721: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:723: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:726: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:727: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:727: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:729: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:731: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:732: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:732: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:734: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:736: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:736: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:738: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:740: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:740: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:744: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:746: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:748: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:750: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:751: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:752: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:754: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:760: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:761: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:761: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:761: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:761: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:768: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:768: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:773: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:778: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:783: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:788: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:793: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:799: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:800: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:804: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:805: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:809: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:810: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:814: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:815: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:819: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:820: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:824: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:825: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:829: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:830: Weird number of spaces at line-start. Are y ou using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:834: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:835: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:839: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:840: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:844: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:845: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:849: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:850: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:854: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:855: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:863: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:868: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:873: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:878: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:883: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:888: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:893: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:898: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:903: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:908: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:913: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:918: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:925: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:930: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:935: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:940: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:945: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:950: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:955: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:960: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:965: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:970: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:975: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:980: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:986: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:991: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:996: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1001: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1006: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1011: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1016: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1021: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1026: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1031: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1036: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1041: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1049: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1056: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1062: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1082: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1083: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1084: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1085: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1085: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1087: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:1089: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1090: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1090: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1090: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1092: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1094: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1095: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1096: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1096: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1098: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:1100: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1101: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1101: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1103: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:421: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/bindings/js/JSDOMPromise.h:210: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/crypto/JsonWebKey.h:40: key_ops is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h:233: The parameter name "scrollbarStyle" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 463 in 708 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 48 2016-11-26 17:35:58 PST

Created attachment 295451 [details] Patch for landing Rebaselining

WebKit Commit Bot

Comment 49 2016-11-26 17:39:55 PST

Attachment 295451 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/DataURLDecoder.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.h:168: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/Connection.h:348: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/PaymentRequest.h:91: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/Optional.h:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/Optional.h:164: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:156: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:157: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WTF/wtf/Optional.h:176: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:177: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:183: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:188: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:189: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:197: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:198: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:199: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:203: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:205: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:206: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:228: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:229: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:233: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:239: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:246: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:253: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:254: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:255: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:257: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:258: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:260: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:270: static_addressof is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:272: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:283: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:283: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:287: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:292: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:293: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:293: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:293: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:294: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:294: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:294: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:296: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:302: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:302: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:302: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:302: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:302: bad_optional_access is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:302: what_arg is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:303: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:303: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:303: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:303: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:303: bad_optional_access is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:303: what_arg is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:309: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:310: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:310: dummy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:311: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:313: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:313: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:313: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:313: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:313: storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:315: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:316: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:316: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:316: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:316: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:316: storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:318: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:318: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:318: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:324: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:325: dummy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:328: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:328: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:328: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:328: constexpr_storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:331: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:331: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:331: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:331: constexpr_storage_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:339: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:340: init_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:341: storage_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:343: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:343: optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:345: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:347: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:350: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:353: optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:354: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:356: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:362: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:363: init_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:364: storage_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:366: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:366: constexpr_optional_base is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:368: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:370: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:373: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:373: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:377: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:377: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:384: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/Optional.h:393: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:394: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:394: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:394: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:395: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:395: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:395: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:398: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:399: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:400: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:403: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:405: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:405: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:406: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:408: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:408: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:409: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:409: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:409: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:412: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:413: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:413: contained_val is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:416: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:417: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:419: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:422: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:423: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:427: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:429: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:430: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:431: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:435: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:438: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:440: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:441: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:441: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:442: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:442: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:444: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:445: Wrong number of spaces before statement. (expected: 6) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:445: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:446: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:451: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:453: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:454: Wrong number of spaces before statement. (expected: 6) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Optional.h:454: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:455: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:457: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:460: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:462: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:462: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:464: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:464: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:466: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:467: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:468: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:468: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:468: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:470: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:472: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:472: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:472: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:475: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:477: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:478: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:479: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:479: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:482: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:484: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:485: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:486: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:486: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:487: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:487: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:488: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:488: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:490: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:492: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:493: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:494: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:495: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:495: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:496: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:496: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:496: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:497: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:497: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:497: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:499: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:501: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:502: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:503: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:504: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:507: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:508: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:509: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:512: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:515: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:516: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:517: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:520: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:522: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:523: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:524: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:527: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:529: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:530: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:531: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:532: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:532: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:532: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:533: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:533: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:533: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:534: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:534: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:535: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:537: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:539: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:541: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:541: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:543: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:547: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:551: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:553: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:555: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:557: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:561: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:563: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:567: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:573: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:579: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:581: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:584: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Optional.h:585: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:589: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:589: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:590: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:594: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:596: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:598: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:598: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:599: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:601: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:603: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:603: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:607: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:609: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:609: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:619: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:620: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:621: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:621: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:627: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:628: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:628: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:629: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:629: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:631: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:635: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:636: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Optional.h:636: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:637: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:637: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:639: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:645: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:646: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:647: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:649: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:658: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:659: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:659: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:659: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:660: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:660: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:660: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:661: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:665: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:666: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:666: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:668: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:668: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:670: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:670: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:672: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:674: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:674: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:676: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:676: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:678: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:680: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:682: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:683: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:686: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:688: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:691: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:693: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:696: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:698: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:699: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:700: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:701: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:704: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:705: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:705: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:708: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:710: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:711: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:712: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:713: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:716: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:717: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:719: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:721: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:723: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:726: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:727: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:727: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:729: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:731: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:732: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:732: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:734: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:736: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:736: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:738: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:740: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:740: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:744: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:746: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:748: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:750: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:751: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:752: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:754: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:760: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:761: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Optional.h:761: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/wtf/Optional.h:761: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:761: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:768: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/Optional.h:768: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:773: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:778: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:783: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:788: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:793: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:799: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:800: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:804: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:805: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:809: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:810: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:814: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:815: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:819: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:820: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:824: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:825: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:829: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:830: Weird number of spaces at line-start. Are y ou using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:834: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:835: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:839: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:840: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:844: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:845: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:849: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:850: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:854: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:855: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:863: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:868: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:873: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:878: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:883: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:888: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:893: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:898: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:903: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:908: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:913: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:918: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:925: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:930: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:935: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:940: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:945: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:950: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:955: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:960: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:965: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:970: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:975: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:980: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:986: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:991: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:996: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1001: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1006: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1011: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1016: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1021: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1026: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1031: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1036: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1041: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1049: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1056: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1062: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1082: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1083: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1084: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1085: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1085: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1087: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:1089: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1090: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1090: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1090: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1092: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1094: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1095: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1096: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1096: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1098: argument_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Optional.h:1100: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Optional.h:1101: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1101: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Optional.h:1101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Optional.h:1103: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:421: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/bindings/js/JSDOMPromise.h:210: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/crypto/JsonWebKey.h:40: key_ops is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h:233: The parameter name "scrollbarStyle" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 463 in 708 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 50 2016-11-26 22:08:46 PST

Committed r208985: <http://trac.webkit.org/changeset/208985>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component Web Template Framework

Assignee

Yusuke Suzuki

Reported

2016-10-29 23:00 PDT

Modified

2016-11-26 22:08 PST History

CC List

13 users Show

URL

Keywords

Depends on

Blocks

162980

Dependancies

tree graph