Bug 164194 – Use #pragma once in WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Joseph Pecoraro]

This uses pragma once in a number of large (dom, html, page) and smaller directories.

  - Convert headers to #pragma once
  - Also cleanup / make consistent closing feature endifs and namespace brace comments.
  - Also remove some unnecessary lines.
  - Add namespace WebCore if missing
  - Add copyright if missing

The goal here was to mostly remove lines and not affect history in a negative way.

[Joseph Pecoraro]

Created attachment 293318 [details]
[PATCH] Proposed Fix

Need to make sure the bots are green.

[Sam Weinig]

Comment on attachment 293318 [details]
[PATCH] Proposed Fix

rs=me

[Joseph Pecoraro]

Created attachment 293433 [details]
[PATCH] For Bots

[Joseph Pecoraro]

> In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/mac/DOM/DOMHTML.mm:41:
> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/HTMLInputElement.h:28:
> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/HTMLTextFormControlElement.h:27:
> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/HTMLFormControlElementWithState.h:26:
> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/HTMLFormControlElement.h:31:
> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/Autocapitalize.h:28:
> /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/WebAutocapitalize.h:34:3: error: typedef redefinition with different types ('enum WebAutocapitalizeType' vs 'enum WebAutocapitalizeType')
> } WebAutocapitalizeType;
>   ^
> In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/mac/DOM/DOMHTML.mm:36:
> In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/mac/DOM/DOMPrivate.h:30:
> /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebKitLegacy.framework/PrivateHeaders/WebAutocapitalize.h:34:3: note: previous definition is here
> } WebAutocapitalizeType;
>   ^
> 6 errors generated.

Apparently WebAutocapitalize is SPI.

I'll not #pragma once it.

[Joseph Pecoraro]

Created attachment 293439 [details]
[PATCH] For Bots

[WebKit Commit Bot]

Comment on attachment 293439 [details]
[PATCH] For Bots

Clearing flags on attachment: 293439

Committed r208179: <http://trac.webkit.org/changeset/208179>