Bug 164194 - Use #pragma once in WebCore
Summary: Use #pragma once in WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-29 16:47 PDT by Joseph Pecoraro
Modified: 2016-11-04 20:07 PDT (History)
2 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (361.18 KB, patch)
2016-10-29 16:56 PDT, Joseph Pecoraro 		sam: review+
Details | Formatted Diff | Diff
[PATCH] For Bots (360.49 KB, patch)
2016-10-31 10:50 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] For Bots (359.89 KB, patch)
2016-10-31 11:09 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-10-29 16:47:04 PDT 
This uses pragma once in a number of large (dom, html, page) and smaller directories.

  - Convert headers to #pragma once
  - Also cleanup / make consistent closing feature endifs and namespace brace comments.
  - Also remove some unnecessary lines.
  - Add namespace WebCore if missing
  - Add copyright if missing

The goal here was to mostly remove lines and not affect history in a negative way.
Comment 1 Joseph Pecoraro 2016-10-29 16:56:56 PDT 
Created attachment 293318 [details]
[PATCH] Proposed Fix

Need to make sure the bots are green.
Comment 2 Sam Weinig 2016-10-29 17:20:04 PDT 
Comment on attachment 293318 [details]
[PATCH] Proposed Fix

rs=me
Comment 3 Joseph Pecoraro 2016-10-31 10:50:23 PDT 
Created attachment 293433 [details]
[PATCH] For Bots
Comment 4 Joseph Pecoraro 2016-10-31 11:08:47 PDT 
> In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/mac/DOM/DOMHTML.mm:41:
> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/HTMLInputElement.h:28:
> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/HTMLTextFormControlElement.h:27:
> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/HTMLFormControlElementWithState.h:26:
> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/HTMLFormControlElement.h:31:
> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/Autocapitalize.h:28:
> /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/WebAutocapitalize.h:34:3: error: typedef redefinition with different types ('enum WebAutocapitalizeType' vs 'enum WebAutocapitalizeType')
> } WebAutocapitalizeType;
>   ^
> In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/mac/DOM/DOMHTML.mm:36:
> In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/mac/DOM/DOMPrivate.h:30:
> /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebKitLegacy.framework/PrivateHeaders/WebAutocapitalize.h:34:3: note: previous definition is here
> } WebAutocapitalizeType;
>   ^
> 6 errors generated.

Apparently WebAutocapitalize is SPI.

I'll not #pragma once it.
Comment 5 Joseph Pecoraro 2016-10-31 11:09:31 PDT 
Created attachment 293439 [details]
[PATCH] For Bots
Comment 6 WebKit Commit Bot 2016-10-31 15:10:56 PDT 
Comment on attachment 293439 [details]
[PATCH] For Bots

Clearing flags on attachment: 293439

Committed r208179: <http://trac.webkit.org/changeset/208179>