Bug 164174 - Remove some unnecessary includes
Summary: Remove some unnecessary includes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-28 22:06 PDT by Joseph Pecoraro
Modified: 2016-10-29 14:15 PDT (History)
2 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (55.92 KB, patch)
2016-10-28 22:07 PDT, Joseph Pecoraro
mcatanzaro: review-
joepeck: commit-queue-
Details | Formatted Diff | Diff
[PATCH] Proposed Fix (55.42 KB, patch)
2016-10-29 10:53 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-10-28 22:06:26 PDT
Remove some unnecessary includes
Comment 1 Joseph Pecoraro 2016-10-28 22:07:08 PDT
Created attachment 293275 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2016-10-28 22:09:21 PDT
Attachment 293275 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/ComposedTreeAncestorIterator.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Catanzaro 2016-10-29 08:45:26 PDT
Comment on attachment 293275 [details]
[PATCH] Proposed Fix

Always a worthwhile task, but looks like it broke iOS and EFL.
Comment 4 Joseph Pecoraro 2016-10-29 10:53:44 PDT
Created attachment 293298 [details]
[PATCH] Proposed Fix

Lets give the bots a try here.
Comment 5 WebKit Commit Bot 2016-10-29 10:55:19 PDT
Attachment 293298 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/ComposedTreeAncestorIterator.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Joseph Pecoraro 2016-10-29 11:38:54 PDT
Comment on attachment 293298 [details]
[PATCH] Proposed Fix

Builds!
Comment 7 Darin Adler 2016-10-29 13:52:39 PDT
Sure would be neat to have a bot that just tries this year round. Keeps trying to remove includes and forward declarations and we only see patches once the bot gets it compiling on all platforms.
Comment 8 WebKit Commit Bot 2016-10-29 14:15:47 PDT
Comment on attachment 293298 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 293298

Committed r208112: <http://trac.webkit.org/changeset/208112>
Comment 9 WebKit Commit Bot 2016-10-29 14:15:50 PDT
All reviewed patches have been landed.  Closing bug.