Convert more of DOM from ExceptionCode to Exception
Created attachment 293274 [details] Patch
After this patch, the only 8 remaining IDL files using LegacyException are: ChildNode.idl Document.idl Element.idl EventTarget.idl NamedNodeMap.idl Node.idl ParentNode.idl Range.idl
Comment on attachment 293274 [details] Patch Attachment 293274 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2397576 New failing tests: imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor.html
Created attachment 293280 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 293274 [details] Patch Attachment 293274 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2397607 New failing tests: fast/mediastream/RTCRtpSender-replaceTrack.html imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor.html fast/mediastream/RTCPeerConnection.html
Created attachment 293281 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 293274 [details] Patch Attachment 293274 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2397582 New failing tests: imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor.html
Created attachment 293282 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 293274 [details] Patch Attachment 293274 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2397617 New failing tests: imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor.html
Created attachment 293284 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 293274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293274&action=review > Source/WebCore/Modules/mediastream/RTCConfiguration.h:45 > class RTCConfiguration : public RefCounted<RTCConfiguration> { A bunch of WebRTC classes have been made ref-counted without actually needed it. This one should be made a struct, as well as RTCOffer/Answer as you noted. > Source/WebCore/Modules/mediastream/RTCConfiguration.idl:33 > ] interface RTCConfiguration { RTCConfiguration should be a dictionary as per the spec.
Created attachment 293294 [details] Patch
Created attachment 293295 [details] Patch
Created attachment 293296 [details] Patch
Comment on attachment 293296 [details] Patch Attachment 293296 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2400285 New failing tests: fast/mediastream/RTCRtpSender-replaceTrack.html
Created attachment 293297 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 293310 [details] Patch
Comment on attachment 293310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293310&action=review > Source/WebCore/Modules/mediastream/RTCOfferAnswerOptions.h:53 > +// FIXME: Why is this reference counted? > +class RTCOfferOptions : public RefCounted<RTCOfferOptions>, public RTCOfferAnswerOptions { It seems that we can keep RTCOfferAnswerOptions RefCounted and add a FIXME there instead. I don't think it's really cleaner to use RefCounted<> in two subclasses of RTCOfferAnswerOptions. > Source/WebCore/editing/InsertIntoTextNodeCommand.cpp:72 > +// FIXME: Why would reapply be iOS-specific? > void InsertIntoTextNodeCommand::doReapply() I guess the only difference would be that we don't momentarilyRevealLastTypedCharacter on iOS upon redo.
Comment on attachment 293310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293310&action=review >> Source/WebCore/Modules/mediastream/RTCOfferAnswerOptions.h:53 >> +class RTCOfferOptions : public RefCounted<RTCOfferOptions>, public RTCOfferAnswerOptions { > > It seems that we can keep RTCOfferAnswerOptions RefCounted and add a FIXME there instead. > I don't think it's really cleaner to use RefCounted<> in two subclasses of RTCOfferAnswerOptions. But it's more efficient. No need for virtual destructor.
Comment on attachment 293310 [details] Patch Clearing flags on attachment: 293310 Committed r208118: <http://trac.webkit.org/changeset/208118>
All reviewed patches have been landed. Closing bug.