Bug 164172 - Web Inspector: Breakpoints not working in scripts with unicode characters
Summary: Web Inspector: Breakpoints not working in scripts with unicode characters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-10-28 20:02 PDT by Joseph Pecoraro
Modified: 2016-10-28 20:19 PDT (History)
12 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (7.97 KB, patch)
2016-10-28 20:04 PDT, Joseph Pecoraro 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-10-28 20:02:36 PDT 
Summary:
Breakpoints not working in scripts with unicode characters

Oops, missed a call site to construct the parser to populate the debugger data struct. I blame optional parameters =(
Comment 1 Joseph Pecoraro 2016-10-28 20:02:48 PDT 
<rdar://problem/28895862>
Comment 2 Joseph Pecoraro 2016-10-28 20:04:21 PDT 
Created attachment 293267 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-10-28 20:06:27 PDT 
Comment on attachment 293267 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=293267&action=review

> LayoutTests/inspector/debugger/breakpoints/resolved-dump-all-pause-locations.html:4
> +<meta http-equiv="Content-Type" content="text/html; charset=utf-8">

I think I can use <meta charset="utf-8"> which is slightly nicer =)
Comment 4 Yusuke Suzuki 2016-10-28 20:10:56 PDT 
Comment on attachment 293267 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=293267&action=review

r=me too :)

> LayoutTests/inspector/debugger/breakpoints/resources/dump-unicode.js:2
> +var unicodeVariableStr = "Non-8-bit 'â' character.";

I recommend adding some unicode string that includes surrogate pairs.
Comment 5 Joseph Pecoraro 2016-10-28 20:19:28 PDT 
<https://trac.webkit.org/changeset/208097>