Bug 164153 - [CSS Parser] Support hanging-punctuation
Summary: [CSS Parser] Support hanging-punctuation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-28 14:32 PDT by Dave Hyatt
Modified: 2016-10-28 14:55 PDT (History)
0 users

See Also:


Attachments
Patch (2.71 KB, patch)
2016-10-28 14:33 PDT, Dave Hyatt
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2016-10-28 14:32:48 PDT
[CSS Parser] Support hanging-punctuation
Comment 1 Dave Hyatt 2016-10-28 14:33:50 PDT
Created attachment 293218 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-10-28 14:44:34 PDT
Comment on attachment 293218 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293218&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:3156
> +    std::bitset<numCSSValueKeywords> seenValues;

Do we really need a bitset with 906 entries when we're just looking for a few values?
Comment 3 Dave Hyatt 2016-10-28 14:55:26 PDT
Landed in r208073.