Bug 164112 – Remove testharness.js/testharnessreport.js unnecessary copies

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[youenn fablet]

This may be buggy to have multiple copies of them

[youenn fablet]

Created attachment 293122 [details]
Patch

[youenn fablet]

This patch removes legacy http/tests/w3c/webperf tests.
These tests have not been modified since 3 years and are skipped in all bots (except for GTK which mark most of them as failing).

[youenn fablet]

(In reply to comment #2)
> This patch removes legacy http/tests/w3c/webperf tests.
> These tests have not been modified since 3 years and are skipped in all bots
> (except for GTK which mark most of them as failing).

From IRC discussions, it is ok to drop those tests for GTK as well.

[Yoav Weiss]

I'm fine with the removal of the webperf imported tests. These features are still being worked on, but don't pass the tests yet AFAIK. We could reintroduce the tests once the features pass them.

Adding Alex, who might be working on said features.

[youenn fablet]

(In reply to comment #4)
> I'm fine with the removal of the webperf imported tests. These features are
> still being worked on, but don't pass the tests yet AFAIK. We could
> reintroduce the tests once the features pass them.

The idea would be to remove these tests now and reintroduce them from W3C WPT repository.
For instance WebKit LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html is related to WPT navigation-timing directory AFAICT.

[Yoav Weiss]

Sounds good!(In reply to comment #5)
> (In reply to comment #4)
> > I'm fine with the removal of the webperf imported tests. These features are
> > still being worked on, but don't pass the tests yet AFAIK. We could
> > reintroduce the tests once the features pass them.
> 
> The idea would be to remove these tests now and reintroduce them from W3C
> WPT repository.
> For instance WebKit
> LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html is
> related to WPT navigation-timing directory AFAICT.

Sounds good! :)

[WebKit Commit Bot]

Comment on attachment 293122 [details]
Patch

Rejecting attachment 293122 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 293122, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 208099 = 66d8e90babcdac1269132e19769878e18d3f77fa
r208100 = c8973df7bd91af94530296652f8a65d23a7b3167
r208101 = 796025edcfd4a25fa7bbddc44fd67e8acb8df5e3
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Total errors found: 0 in 1 files

Full output: http://webkit-queues.webkit.org/results/2399485

[WebKit Commit Bot]

Comment on attachment 293122 [details]
Patch

Clearing flags on attachment: 293122

Committed r208105: <http://trac.webkit.org/changeset/208105>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.