[WebGL2] Implement getBufferSubData()
Created attachment 293119 [details] Patch
Attachment 293119 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 293124 [details] WIP
Attachment 293124 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:715: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:718: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 293251 [details] Patch
Attachment 293251 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:715: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:718: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
*** Bug 164024 has been marked as a duplicate of this bug. ***
Created attachment 293256 [details] Patch
Attachment 293256 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:715: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:718: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 293256 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293256&action=review > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:576 > + return ::glMapBufferRange(target, offset, length, access); It looks like these need to be inside #if ENABLE(WEBGL2) or something. It doesn't exist in GLESv2 headers
Created attachment 293277 [details] Patch
Attachment 293277 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:715: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:718: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 293277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293277&action=review > Source/WebCore/ChangeLog:12 > + The call exists in OpenGL 3.2 but not OpenGL ES 3. On OpenGL > + ES, we need to call glMapBufferRange() instead. > + > + OpenGL 3.2 also has glMapBufferRange, so perhaps this > + implementation should be used on both systems. I agree. > Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:203 > + synthesizeGLError(GraphicsContext3D::INVALID_OPERATION, "getBufferSubData", "dstOffset is too high"); Rather than "too high" in all the error messages, I think we should be more explicit. e.g. dstOffset is larger than the length/size of the destination buffer. > Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:232 > + synthesizeGLError(GraphicsContext3D::INVALID_OPERATION, "getBufferSubData", "Reading too far in the source array"); e.g. "Parameters would read outside the bounds of the source buffer." > Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:237 > + synthesizeGLError(GraphicsContext3D::INVALID_OPERATION, "getBufferSubData", "WebGL buffer is too small"); e.g. "something more explicit here :)"
Created attachment 293816 [details] Patch for committing
Created attachment 293826 [details] Patch for committing
Attachment 293826 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:715: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:718: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 293833 [details] Patch for committing
Attachment 293833 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:715: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:718: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 293833 [details] Patch for committing Clearing flags on attachment: 293833 Committed r208363: <http://trac.webkit.org/changeset/208363>