Bug 164101 - Update ANGLE
Summary: Update ANGLE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-27 18:13 PDT by Alex Christensen
Modified: 2016-11-29 01:42 PST (History)
3 users (show)

See Also:


Attachments
Patch (11.00 MB, patch)
2016-10-27 18:28 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
patch (10.48 MB, patch)
2016-10-27 18:59 PDT, Alex Christensen
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-10-27 18:13:27 PDT
Update ANGLE
Comment 1 Alex Christensen 2016-10-27 18:28:30 PDT
Created attachment 293093 [details]
Patch
Comment 2 Alex Christensen 2016-10-27 18:59:31 PDT
Created attachment 293099 [details]
patch
Comment 3 WebKit Commit Bot 2016-10-27 19:15:00 PDT
Attachment 293099 [details] did not pass style-queue:


ERROR: Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/resolvedepthstencil11_ps.h:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/resolvedepth11_ps.h:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/resolvedepthstencil11_vs.h:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/passthroughrgbapremultiply2d11ps.h:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/resolvestencil11_ps.h:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/passthroughrgbpremultiply2d11ps.h:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/passthroughrgbaunmultiply2d11ps.h:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/passthroughrgbunmultiply2d11ps.h:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 764 in 919 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Darin Adler 2016-10-27 20:33:04 PDT
Comment on attachment 293099 [details]
patch

rs=me
Comment 5 Alex Christensen 2016-10-27 23:04:02 PDT
https://trac.webkit.org/r208036
Comment 6 Alex Christensen 2016-10-27 23:05:05 PDT
I also replaced some tabs with spaces in these files:
    src/tests/compiler_tests/QualificationOrder_test.cpp
    src/tests/third_party/rapidjson/include/rapidjson/prettywriter.h
    src/tests/third_party/rapidjson/include/rapidjson/reader.h
    src/tests/third_party/rapidjson/include/rapidjson/writer.h
    src/third_party/murmurhash/MurmurHash3.h
Comment 7 Jeremy Huddleston Sequoia 2016-11-29 01:42:21 PST
Caused: https://bugs.webkit.org/show_bug.cgi?id=165135