Bug 164099 - One file per class for Executable.h/.cpp
Summary: One file per class for Executable.h/.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-27 17:28 PDT by Geoffrey Garen
Modified: 2016-10-28 14:01 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.10 MB, patch)
2016-10-27 17:30 PDT, Geoffrey Garen 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2016-10-27 17:28:01 PDT 
One file per class for Executable.h/.cpp
Comment 1 Geoffrey Garen 2016-10-27 17:30:42 PDT 
Created attachment 293087 [details]
Patch
Comment 2 Geoffrey Garen 2016-10-27 17:31:14 PDT 
This is a first step toward fixing some problems with code caching.
Comment 3 Saam Barati 2016-10-28 01:27:49 PDT 
Comment on attachment 293087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293087&action=review

r=me

I wish bugzilla did a better job with showing diffs for these patches.

> PerformanceTests/ChangeLog:1
> +2016-10-27  Geoffrey Garen  <ggaren@apple.com>

Is this change expected?
Comment 4 Geoffrey Garen 2016-10-28 12:24:23 PDT 
> > PerformanceTests/ChangeLog:1
> > +2016-10-27  Geoffrey Garen  <ggaren@apple.com>
> 
> Is this change expected?

Oops! Fixed.
Comment 5 Geoffrey Garen 2016-10-28 13:07:48 PDT 
Committed r208063: <http://trac.webkit.org/changeset/208063>
Comment 6 Csaba Osztrogonác 2016-10-28 14:01:55 PDT 
(In reply to comment #5)
> Committed r208063: <http://trac.webkit.org/changeset/208063>

It broke the CLoop build, see build.webkit.org for details.