Instead of using an array/dictionary for holding related model objects (such as how a WI.DOMTree has a list of WI.ContentFlow), we can make use of the new WI.Collection model object for more extensibility and control.
Created attachment 293088 [details] Patch
Comment on attachment 293088 [details] Patch Attachment 293088 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2389439 New failing tests: inspector/dom/highlightNode.html inspector/dom/highlightSelector.html inspector/dom/highlightFrame.html http/tests/inspector/console/cross-domain-inspected-node-access.html
Created attachment 293095 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 293088 [details] Patch Attachment 293088 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2389440 New failing tests: inspector/dom/highlightNode.html inspector/dom/highlightSelector.html inspector/dom/highlightFrame.html http/tests/inspector/console/cross-domain-inspected-node-access.html
Created attachment 293096 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 293088 [details] Patch Attachment 293088 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2389493 New failing tests: inspector/dom/highlightNode.html inspector/dom/highlightSelector.html inspector/dom/highlightFrame.html http/tests/inspector/console/cross-domain-inspected-node-access.html
Created attachment 293098 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 293100 [details] Patch
Comment on attachment 293100 [details] Patch Attachment 293100 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2389915 New failing tests: inspector/dom/highlightNode.html inspector/dom/highlightSelector.html inspector/dom/highlightFrame.html http/tests/inspector/console/cross-domain-inspected-node-access.html
Created attachment 293104 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 293100 [details] Patch Attachment 293100 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2389917 New failing tests: inspector/dom/highlightNode.html inspector/dom/highlightSelector.html inspector/dom/highlightFrame.html http/tests/inspector/console/cross-domain-inspected-node-access.html
Created attachment 293105 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 293100 [details] Patch Attachment 293100 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2389954 New failing tests: inspector/dom/highlightNode.html inspector/dom/highlightSelector.html inspector/dom/highlightFrame.html http/tests/inspector/console/cross-domain-inspected-node-access.html
Created attachment 293107 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 293110 [details] Patch
Comment on attachment 293110 [details] Patch Where is Collection.js? I don't see that in this patch.
Nevermind, my checkout was old. I see Collection.js now.
Comment on attachment 293110 [details] Patch Clearing flags on attachment: 293110 Committed r208246: <http://trac.webkit.org/changeset/208246>
All reviewed patches have been landed. Closing bug.
Comment on attachment 293110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293110&action=review > Source/WebInspectorUI/UserInterface/Models/Collection.js:115 > + ContentFlow: (object) => object instanceof WebInspector.ContentFlow, I don't think this deserves a global. Just inline it in DOMTree. > LayoutTests/inspector/dom/highlightNode-expected.txt:4 > +PASS: Page should have a subframe. It is weird to have a PASS outside of a running test case.
<rdar://problem/29054784>