WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
164098
Web Inspector: Replace sublists inside DOM-related model objects with WI.Collection
https://bugs.webkit.org/show_bug.cgi?id=164098
Summary
Web Inspector: Replace sublists inside DOM-related model objects with WI.Coll...
Devin Rousso
Reported
2016-10-27 17:21:37 PDT
Instead of using an array/dictionary for holding related model objects (such as how a WI.DOMTree has a list of WI.ContentFlow), we can make use of the new WI.Collection model object for more extensibility and control.
Attachments
Patch
(48.36 KB, patch)
2016-10-27 17:33 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2
(1.29 MB, application/zip)
2016-10-27 18:36 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews112 for mac-yosemite
(1.80 MB, application/zip)
2016-10-27 18:46 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews101 for mac-yosemite
(934.94 KB, application/zip)
2016-10-27 18:49 PDT
,
Build Bot
no flags
Details
Patch
(48.25 KB, patch)
2016-10-27 19:25 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews103 for mac-yosemite
(958.88 KB, application/zip)
2016-10-27 20:24 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2
(1.08 MB, application/zip)
2016-10-27 20:27 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews114 for mac-yosemite
(1.73 MB, application/zip)
2016-10-27 20:42 PDT
,
Build Bot
no flags
Details
Patch
(48.24 KB, patch)
2016-10-27 21:20 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Show Obsolete
(8)
View All
Add attachment
proposed patch, testcase, etc.
Devin Rousso
Comment 1
2016-10-27 17:33:52 PDT
Created
attachment 293088
[details]
Patch
Build Bot
Comment 2
2016-10-27 18:36:29 PDT
Comment on
attachment 293088
[details]
Patch
Attachment 293088
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/2389439
New failing tests: inspector/dom/highlightNode.html inspector/dom/highlightSelector.html inspector/dom/highlightFrame.html http/tests/inspector/console/cross-domain-inspected-node-access.html
Build Bot
Comment 3
2016-10-27 18:36:32 PDT
Created
attachment 293095
[details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 4
2016-10-27 18:46:25 PDT
Comment on
attachment 293088
[details]
Patch
Attachment 293088
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/2389440
New failing tests: inspector/dom/highlightNode.html inspector/dom/highlightSelector.html inspector/dom/highlightFrame.html http/tests/inspector/console/cross-domain-inspected-node-access.html
Build Bot
Comment 5
2016-10-27 18:46:28 PDT
Created
attachment 293096
[details]
Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 6
2016-10-27 18:49:06 PDT
Comment on
attachment 293088
[details]
Patch
Attachment 293088
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/2389493
New failing tests: inspector/dom/highlightNode.html inspector/dom/highlightSelector.html inspector/dom/highlightFrame.html http/tests/inspector/console/cross-domain-inspected-node-access.html
Build Bot
Comment 7
2016-10-27 18:49:09 PDT
Created
attachment 293098
[details]
Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Devin Rousso
Comment 8
2016-10-27 19:25:14 PDT
Created
attachment 293100
[details]
Patch
Build Bot
Comment 9
2016-10-27 20:24:21 PDT
Comment on
attachment 293100
[details]
Patch
Attachment 293100
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/2389915
New failing tests: inspector/dom/highlightNode.html inspector/dom/highlightSelector.html inspector/dom/highlightFrame.html http/tests/inspector/console/cross-domain-inspected-node-access.html
Build Bot
Comment 10
2016-10-27 20:24:24 PDT
Created
attachment 293104
[details]
Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 11
2016-10-27 20:27:00 PDT
Comment on
attachment 293100
[details]
Patch
Attachment 293100
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/2389917
New failing tests: inspector/dom/highlightNode.html inspector/dom/highlightSelector.html inspector/dom/highlightFrame.html http/tests/inspector/console/cross-domain-inspected-node-access.html
Build Bot
Comment 12
2016-10-27 20:27:03 PDT
Created
attachment 293105
[details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 13
2016-10-27 20:41:57 PDT
Comment on
attachment 293100
[details]
Patch
Attachment 293100
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/2389954
New failing tests: inspector/dom/highlightNode.html inspector/dom/highlightSelector.html inspector/dom/highlightFrame.html http/tests/inspector/console/cross-domain-inspected-node-access.html
Build Bot
Comment 14
2016-10-27 20:42:00 PDT
Created
attachment 293107
[details]
Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Devin Rousso
Comment 15
2016-10-27 21:20:17 PDT
Created
attachment 293110
[details]
Patch
Timothy Hatcher
Comment 16
2016-11-01 14:27:13 PDT
Comment on
attachment 293110
[details]
Patch Where is Collection.js? I don't see that in this patch.
Timothy Hatcher
Comment 17
2016-11-01 14:28:41 PDT
Nevermind, my checkout was old. I see Collection.js now.
WebKit Commit Bot
Comment 18
2016-11-01 14:51:28 PDT
Comment on
attachment 293110
[details]
Patch Clearing flags on attachment: 293110 Committed
r208246
: <
http://trac.webkit.org/changeset/208246
>
WebKit Commit Bot
Comment 19
2016-11-01 14:51:33 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 20
2016-11-01 14:53:14 PDT
Comment on
attachment 293110
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=293110&action=review
> Source/WebInspectorUI/UserInterface/Models/Collection.js:115 > + ContentFlow: (object) => object instanceof WebInspector.ContentFlow,
I don't think this deserves a global. Just inline it in DOMTree.
> LayoutTests/inspector/dom/highlightNode-expected.txt:4 > +PASS: Page should have a subframe.
It is weird to have a PASS outside of a running test case.
Radar WebKit Bug Importer
Comment 21
2016-11-01 16:21:30 PDT
<
rdar://problem/29054784
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug