Bug 164075 – [CSS Parser] Implement CSS variables

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dave Hyatt]

[CSS Parser] Implement CSS variables

[Dave Hyatt]

Created attachment 293052 [details]
Patch

[WebKit Commit Bot]

Attachment 293052 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSVariableData.h:63:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 293053 [details]
Patch

[Dean Jackson]

Comment on attachment 293053 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293053&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:3425
> -		9444CBE81D8861C20073A074 /* CSSVariableData.h in Headers */ = {isa = PBXBuildFile; fileRef = 9444CBDD1D8861580073A074 /* CSSVariableData.h */; };
> +		9444CBE81D8861C20073A074 /* CSSVariableData.h in Headers */ = {isa = PBXBuildFile; fileRef = 9444CBDD1D8861580073A074 /* CSSVariableData.h */; settings = {ATTRIBUTES = (Private, ); }; };

Was this intentional?

> Source/WebCore/css/CSSVariableData.cpp:109
> +            AtomicString variableName =
> +            block.consumeIncludingWhitespace().value().toAtomicString();

Typo. Accidental newline.

> Source/WebCore/css/parser/CSSParser.cpp:1809
> +        const CSSVariableDependentValue& dependentValue = downcast<CSSVariableDependentValue>(value);

You could probably auto this.

> Source/WebCore/css/parser/CSSParser.cpp:1814
> +        CSSPropertyID dependentValuePropertyID = dependentValue.propertyID();

And this. etc.

> Source/WebCore/css/parser/CSSParser.cpp:1858
> +        const CSSVariableReferenceValue& valueWithReferences = downcast<CSSVariableReferenceValue>(value);
> +        const CSSVariableData* variableData = valueWithReferences.variableDataValue();

More autos.

> Source/WebCore/css/parser/CSSParserImpl.cpp:95
> -            CSSCustomPropertyValue* customValue = downcast<CSSCustomPropertyValue>(property.value());
> -            const AtomicString& name = customValue->name();
> -            if (seenCustomProperties.contains(name))
> +            auto& name = downcast<CSSCustomPropertyValue>(*property.value()).name();
> +            if (!seenCustomProperties.add(name).isNewEntry)
>                  continue;
> -            seenCustomProperties.add(name);
> +            output[--unusedEntries] = property;
>              continue;
>          }

I don't understand this change.

[Dave Hyatt]

Created attachment 293054 [details]
Patch

[Dean Jackson]

Comment on attachment 293054 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293054&action=review

> Source/WebCore/css/CSSVariableData.cpp:108
> +            AtomicString variableName =

This still needs fixing.

[Dave Hyatt]

Created attachment 293062 [details]
Patch

[Dave Hyatt]

Landed in r208006.