Bug 164073 - Web Inspector: Worker should recover if Inspector is closed and never sent Worker.initialized command
Summary: Web Inspector: Worker should recover if Inspector is closed and never sent Wo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on: 163844
Blocks:
  Show dependency treegraph
 
Reported: 2016-10-27 13:30 PDT by Joseph Pecoraro
Modified: 2016-10-27 15:23 PDT (History)
6 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (5.63 KB, patch)
2016-10-27 13:33 PDT, Joseph Pecoraro
bburg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-10-27 13:30:59 PDT
Summary:
Worker should recover if Inspector is closed and never sent Worker.initialized command

In the unlikely event that the Inspector crashes and disconnects from a Worker during initialization it could leave the Worker paused waiting for debugger messages. When we disconnect from a worker we should terminate the debugger message only run loop mode.
Comment 1 Joseph Pecoraro 2016-10-27 13:33:56 PDT
Created attachment 293050 [details]
[PATCH] Proposed Fix
Comment 2 Brian Burg 2016-10-27 13:36:49 PDT
Comment on attachment 293050 [details]
[PATCH] Proposed Fix

Very nice, r=me
Comment 3 Joseph Pecoraro 2016-10-27 15:23:53 PDT
<https://trac.webkit.org/changeset/208011>