Bug 164045 – A fill-forwards opacity animation never reached 1.0

• Status: RESOLVED
• Resolution: INVALID
• Component: Animations

[Simon Fraser (smfr)]

A fill-forwards opacity animation never reached 1.0

[Simon Fraser (smfr)]

Created attachment 292972 [details]
Patch

[Dean Jackson]

Comment on attachment 292972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292972&action=review

> LayoutTests/animations/opacity-reaches-one.html:47
> +        window.addEventListener('load', function() {
> +            document.getElementById('animating').addEventListener('animationend', function() {
> +                if (window.testRunner)
> +                    testRunner.notifyDone();
> +            })
> +        }, false);

Couldn't you just put the 'animationend' listener on document? Saves the 'load' listener.

[Build Bot]

Comment on attachment 292972 [details]
Patch

Attachment 292972 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2381640

New failing tests:
fast/css/image-set-value-not-removed-crash.html
compositing/visible-rect/animated-from-none.html
compositing/layer-creation/animation-overlap-with-children.html
compositing/layer-creation/mismatched-rotated-transform-animation-overlap.html

[Build Bot]

Created attachment 292978 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 292972 [details]
Patch

Attachment 292972 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2381654

New failing tests:
fast/css/image-set-value-not-removed-crash.html
compositing/visible-rect/animated-from-none.html
compositing/layer-creation/animation-overlap-with-children.html
compositing/layer-creation/mismatched-rotated-transform-animation-overlap.html

[Build Bot]

Created attachment 292979 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 292972 [details]
Patch

Attachment 292972 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2381676

New failing tests:
fast/css/image-set-value-not-removed-crash.html
compositing/layer-creation/mismatched-rotated-transform-animation-overlap.html
compositing/layer-creation/animation-overlap-with-children.html
compositing/visible-rect/animated-from-none.html

[Build Bot]

Created attachment 292980 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 292972 [details]
Patch

Attachment 292972 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2381656

New failing tests:
fast/css/image-set-value-not-removed-crash.html

[Build Bot]

Created attachment 292981 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Simon Fraser (smfr)]

Tests are failing because this change affects whether we create stacking context during animations.

[Simon Fraser (smfr)]

Created attachment 293194 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 293197 [details]
Patch for EWS

[Build Bot]

Comment on attachment 293197 [details]
Patch for EWS

Attachment 293197 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2394960

New failing tests:
animations/opacity-reaches-one.html
fast/css/image-set-value-not-removed-crash.html
compositing/layer-creation/mismatched-rotated-transform-animation-overlap.html
compositing/layer-creation/animation-overlap-with-children.html
compositing/visible-rect/animated-from-none.html

[Build Bot]

Created attachment 293212 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 293197 [details]
Patch for EWS

Attachment 293197 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2395024

New failing tests:
animations/opacity-reaches-one.html
fast/css/image-set-value-not-removed-crash.html
compositing/layer-creation/mismatched-rotated-transform-animation-overlap.html
compositing/layer-creation/animation-overlap-with-children.html
compositing/visible-rect/animated-from-none.html

[Build Bot]

Created attachment 293213 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 293197 [details]
Patch for EWS

Attachment 293197 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2395051

New failing tests:
animations/opacity-reaches-one.html
fast/css/image-set-value-not-removed-crash.html

[Build Bot]

Comment on attachment 293197 [details]
Patch for EWS

Attachment 293197 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2395048

New failing tests:
animations/opacity-reaches-one.html
fast/css/image-set-value-not-removed-crash.html
compositing/visible-rect/animated-from-none.html
compositing/layer-creation/animation-overlap-with-children.html
compositing/layer-creation/mismatched-rotated-transform-animation-overlap.html

[Build Bot]

Created attachment 293220 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 293197 [details]
Patch for EWS

Attachment 293197 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2395788

New failing tests:
fast/css/image-set-value-not-removed-crash.html
animations/opacity-reaches-one.html

[Build Bot]

Created attachment 293241 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Attached patches are now well over 6 year-old, this pre-dating the rewrite of much of the animation code, and there is no test about this fairly generically-titled bug. Going to mark this as INVALID since it's not really actionable anymore.