NEW 164035
Web Inspector: clean up diverging code paths in InspectorFrontendAPI 
https://bugs.webkit.org/show_bug.cgi?id=164035
Summary Web Inspector: clean up diverging code paths in InspectorFrontendAPI
Blaze Burg
Reported 2016-10-26 14:57:36 PDT
- Get rid of separate code paths to dispatch sync (skips MessageDispatcher) and async. It should always be 'async'. We could not deliver a message right away even in the sync case because we hold onto frontend API commands while the page is paused. - On the frontend side, InspectorFrontendAPI.dispatch actually defers calls to InspectorFrontendAPI messages. The name 'dispatch' is misleading. - On the backend side, clients of WebInspectorFrontendAPIDispatcher need to pass in a string(!) to name the InspectorFrontendAPI command they want to call. It should just expose instance methods that fill in the correct string.
Attachments
Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2016-10-26 14:57:52 PDT
Oh, also it needs some tests.
Radar WebKit Bug Importer
Comment 2 2016-11-01 17:04:33 PDT
<rdar://problem/29055605>
Note You need to log in before you can comment on or make changes to this bug.