Bug 164035 - Web Inspector: clean up diverging code paths in InspectorFrontendAPI
Summary: Web Inspector: clean up diverging code paths in InspectorFrontendAPI
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-10-26 14:57 PDT by Brian Burg
Modified: 2016-12-13 15:36 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2016-10-26 14:57:36 PDT
- Get rid of separate code paths to dispatch sync (skips MessageDispatcher) and async. It should always be 'async'. We could not deliver a message right away even in the sync case because we hold onto frontend API commands while the page is paused.
- On the frontend side, InspectorFrontendAPI.dispatch actually defers calls to InspectorFrontendAPI messages. The name 'dispatch' is misleading.
- On the backend side, clients of WebInspectorFrontendAPIDispatcher need to pass in a string(!) to name the InspectorFrontendAPI command they want to call. It should just expose instance methods that fill in the correct string.
Comment 1 Brian Burg 2016-10-26 14:57:52 PDT
Oh, also it needs some tests.
Comment 2 Radar WebKit Bug Importer 2016-11-01 17:04:33 PDT
<rdar://problem/29055605>