[EME] Add no-op Web-facing APIs
The idea is to start with WebIDL definitions and the underlying C++ classes. The implementations would be non-operational for starters, with future patches implementing the relevant algorithms and queries to the platform layer. Incoming patch needs a few more iterations, mostly for the Xcode and Windows build systems, but the gist of it is reviewable.
Created attachment 292957 [details] WIP
Created attachment 293009 [details] WIP
Created attachment 293555 [details] WIP Trying to get the patch building on all EWS configs.
Attachment 293555 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSMediaKeySystemAccessCustom.cpp:33: You should add a blank line after implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSMediaKeySystemAccessCustom.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSMediaKeySessionCustom.cpp:33: You should add a blank line after implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSMediaKeySessionCustom.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] Total errors found: 4 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 294154 [details] Patch
Attachment 294154 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSMediaKeySystemAccessCustom.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSMediaKeySessionCustom.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] Total errors found: 2 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 294154 [details] Patch Looks good! We may want to add a runtime-enabled switch for all these new interfaces, in a future patch.
Created attachment 294348 [details] Patch for landing
Attachment 294348 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSMediaKeySystemAccessCustom.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSMediaKeySessionCustom.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] Total errors found: 2 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 294357 [details] Patch for landing
Attachment 294357 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSMediaKeySystemAccessCustom.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSMediaKeySessionCustom.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] Total errors found: 2 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.
The patch needed an update after the generation of promise code was modified I think yesterday. mac-debug EWS is reporting failures, but the bot seems in bad state and the failures in the build it managed to compile aren't related.
Comment on attachment 294357 [details] Patch for landing Clearing flags on attachment: 294357 Committed r208539: <http://trac.webkit.org/changeset/208539>
All reviewed patches have been landed. Closing bug.