RESOLVED FIXED 164026
[cmake][MinGW] Don't use MS bitfield layout to reduce sizes of data structures 
https://bugs.webkit.org/show_bug.cgi?id=164026
Summary [cmake][MinGW] Don't use MS bitfield layout to reduce sizes of data structures
Konstantin Tokarev
Reported 2016-10-26 11:52:15 PDT
With MS bitfileds RegisterAtOffset becomes wider than ptrdiff_t because of different alignment requirements, invoking static_assert. Instead of muting assert for MinGW like it's done for MSVC, it's a better choice to use more dense layout, as bitfields are not used in public APIs. Also, suppress MinGW warnings from "#pragma warning" which it doesn't understand.
Attachments
Patch (1.83 KB, patch)
2016-10-26 11:54 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-10-26 11:54:09 PDT
Created attachment 292953 [details] Patch
Michael Catanzaro
Comment 2 2016-10-26 13:59:30 PDT
Comment on attachment 292953 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292953&action=review > ChangeLog:8 > + With MS bitfileds RegisterAtOffset becomes wider than ptrdiff_t because of bitfileds -> bitfields
WebKit Commit Bot
Comment 3 2016-11-03 15:26:20 PDT
Comment on attachment 292953 [details] Patch Clearing flags on attachment: 292953 Committed r208350: <http://trac.webkit.org/changeset/208350>
WebKit Commit Bot
Comment 4 2016-11-03 15:26:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.