Bug 164026 - [cmake][MinGW] Don't use MS bitfield layout to reduce sizes of data structures
Summary: [cmake][MinGW] Don't use MS bitfield layout to reduce sizes of data structures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-26 11:52 PDT by Konstantin Tokarev
Modified: 2016-11-03 15:26 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.83 KB, patch)
2016-10-26 11:54 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-10-26 11:52:15 PDT 
With MS bitfileds RegisterAtOffset becomes wider than ptrdiff_t because of different alignment requirements, invoking static_assert. Instead of muting assert for MinGW like it's done for MSVC, it's a better choice to use more dense layout, as bitfields are not used in public APIs.
    
Also, suppress MinGW warnings from "#pragma warning" which it doesn't understand.
Comment 1 Konstantin Tokarev 2016-10-26 11:54:09 PDT 
Created attachment 292953 [details]
Patch
Comment 2 Michael Catanzaro 2016-10-26 13:59:30 PDT 
Comment on attachment 292953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292953&action=review

> ChangeLog:8
> +        With MS bitfileds RegisterAtOffset becomes wider than ptrdiff_t because of

bitfileds -> bitfields
Comment 3 WebKit Commit Bot 2016-11-03 15:26:20 PDT 
Comment on attachment 292953 [details]
Patch

Clearing flags on attachment: 292953

Committed r208350: <http://trac.webkit.org/changeset/208350>
Comment 4 WebKit Commit Bot 2016-11-03 15:26:24 PDT 
All reviewed patches have been landed.  Closing bug.