Bug 164020 - First parameter to TextTrack.addCue() / removeCue() should not be nullable
Summary: First parameter to TextTrack.addCue() / removeCue() should not be nullable
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: WebExposed
Depends on:
Reported: 2016-10-26 09:54 PDT by Chris Dumez
Modified: 2016-10-26 12:30 PDT (History)
5 users (show)

See Also:

Patch (13.36 KB, patch)
2016-10-26 09:56 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (13.37 KB, patch)
2016-10-26 10:05 PDT, Chris Dumez
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-26 09:54:50 PDT
First parameter to TextTrack.addCue() / removeCue() should not be nullable:
- https://html.spec.whatwg.org/#texttrack

Firefox and Chrome agree with the specification.
Comment 1 Chris Dumez 2016-10-26 09:56:29 PDT
Created attachment 292937 [details]
Comment 2 Eric Carlson 2016-10-26 10:01:31 PDT
Comment on attachment 292937 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=292937&action=review

> LayoutTests/ChangeLog:11
> +        * fast/media/texttrack-addCue-null-expected.txt: Added.
> +        * fast/media/texttrack-addCue-null.html: Added.

I think this test should be in LayoutTests/media/track/ with the rest of the text track tests. Almost all of the tests in LayoutTests/fast/media/ are for media queries.
Comment 3 Chris Dumez 2016-10-26 10:05:16 PDT
Created attachment 292939 [details]
Comment 4 WebKit Commit Bot 2016-10-26 11:19:43 PDT
Comment on attachment 292939 [details]

Rejecting attachment 292939 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 292939, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/2379801
Comment 5 Chris Dumez 2016-10-26 12:30:13 PDT
Committed r207907: <http://trac.webkit.org/changeset/207907>