Bug 164003 - Updating attribute by textContent must create a single mutation record and custom element reaction
Summary: Updating attribute by textContent must create a single mutation record and cu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 154907
  Show dependency treegraph
 
Reported: 2016-10-25 19:45 PDT by Ryosuke Niwa
Modified: 2016-10-28 20:50 PDT (History)
7 users (show)

See Also:


Attachments
Fixes the bug (8.86 KB, patch)
2016-10-25 19:52 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Adds CEReactions (94.72 KB, patch)
2016-10-28 14:18 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-10-25 19:45:35 PDT
When updating an attribute by its Attr node's textContent,
WebKit currently creates two mutation records and invokes attributeChangedCallback twice.

In accordance with the latest DOM specification,
we should create exactly one mutation record and invoke attributeChangedCallback once.
Comment 1 Radar WebKit Bug Importer 2016-10-25 19:49:44 PDT
<rdar://problem/28951008>
Comment 2 Ryosuke Niwa 2016-10-25 19:52:03 PDT
Created attachment 292866 [details]
Fixes the bug
Comment 3 Chris Dumez 2016-10-25 21:02:46 PDT
Comment on attachment 292866 [details]
Fixes the bug

r=me, good find.
Comment 4 WebKit Commit Bot 2016-10-25 21:47:54 PDT
Comment on attachment 292866 [details]
Fixes the bug

Clearing flags on attachment: 292866

Committed r207864: <http://trac.webkit.org/changeset/207864>
Comment 5 WebKit Commit Bot 2016-10-25 21:47:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryosuke Niwa 2016-10-28 14:18:09 PDT
Reopening to attach new patch.
Comment 7 Ryosuke Niwa 2016-10-28 14:18:12 PDT
Created attachment 293210 [details]
Adds CEReactions
Comment 8 Ryosuke Niwa 2016-10-28 14:18:49 PDT
Comment on attachment 293210 [details]
Adds CEReactions

Oops, wrong bug.