* SUMMARY Apparently, there is a misbehavior with slotted elements when these ones are clicked or hovered. Active state and hover state are not being applied. * HOW TO REPRODUCE Opening this example will be clear enough http://codepen.io/mcorbanini/pen/RGdzAB
<rdar://problem/29040471>
Created attachment 294438 [details] Fixes the bug
Attachment 294438 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebImmediateActionController.mm:153: The parameter name "element" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 294439 [details] Fixes the bug
Attachment 294439 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebImmediateActionController.mm:153: The parameter name "element" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ping reviewers.
Comment on attachment 294439 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=294439&action=review > Source/WebCore/ChangeLog:3 > + Moving the cursor onto a slotted Text node clears hover state What kind of cursor? This makes me think of the mouse cursor but I don't think you mean that. EDIT: oh I guess you do. Maybe reword to use "hover".
(In reply to comment #7) > Comment on attachment 294439 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=294439&action=review > > > Source/WebCore/ChangeLog:3 > > + Moving the cursor onto a slotted Text node clears hover state > > What kind of cursor? This makes me think of the mouse cursor but I don't > think you mean that. > EDIT: oh I guess you do. Maybe reword to use "hover". Thanks for the review. Fixe the bug title.
Created attachment 294560 [details] Patch for landing
Attachment 294560 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebImmediateActionController.mm:153: The parameter name "element" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 294560 [details] Patch for landing Clearing flags on attachment: 294560 Committed r208630: <http://trac.webkit.org/changeset/208630>
All reviewed patches have been landed. Closing bug.