Bug 163994 - [Win][Direct2D] Use smart pointers for Direct2D Path types
Summary: [Win][Direct2D] Use smart pointers for Direct2D Path types
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
Depends on:
Blocks: 163898
  Show dependency treegraph
Reported: 2016-10-25 16:18 PDT by Brent Fulgham
Modified: 2016-10-25 19:00 PDT (History)
6 users (show)

See Also:

Patch (9.74 KB, patch)
2016-10-25 16:28 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-10-25 16:18:50 PDT
Switch the D2D Path implementation to use a smart pointer for Direct2D native path types to reduce memory leaks.
Comment 1 Brent Fulgham 2016-10-25 16:28:34 PDT
Created attachment 292843 [details]

Strip the Path refactoring changes out of Bug 163898.
Comment 2 Alex Christensen 2016-10-25 16:35:49 PDT
Comment on attachment 292843 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=292843&action=review

> Source/WebCore/platform/graphics/Path.h:172
> +#if USE(DIRECT2D)
> +        PlatformPathPtr platformPath() const { return m_path.get(); }
> +#else
>          PlatformPathPtr platformPath() const { return m_path; }
> +#endif

It seems like other platforms ought to follow this and use smart pointers.
Comment 3 WebKit Commit Bot 2016-10-25 19:00:34 PDT
Comment on attachment 292843 [details]

Clearing flags on attachment: 292843

Committed r207863: <http://trac.webkit.org/changeset/207863>
Comment 4 WebKit Commit Bot 2016-10-25 19:00:39 PDT
All reviewed patches have been landed.  Closing bug.