Bug 163966 - IDBDatabase.transaction() should take a union in parameter
Summary: IDBDatabase.transaction() should take a union in parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://www.w3.org/TR/IndexedDB/#widl...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-25 12:39 PDT by Chris Dumez
Modified: 2016-10-25 15:04 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.19 KB, patch)
2016-10-25 13:06 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Chris Dumez 2016-10-25 13:06:12 PDT 
Created attachment 292804 [details]
Patch
Comment 2 Sam Weinig 2016-10-25 14:41:42 PDT 
Comment on attachment 292804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292804&action=review

> Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:179
>      if (objectStores.isEmpty())
>          return Exception { IDBDatabaseException::InvalidAccessError, ASCIILiteral("Failed to execute 'transaction' on 'IDBDatabase': The storeNames parameter was empty.") };

Can this case happen?
Comment 3 Chris Dumez 2016-10-25 14:43:40 PDT 
Comment on attachment 292804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292804&action=review

>> Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:179
>>          return Exception { IDBDatabaseException::InvalidAccessError, ASCIILiteral("Failed to execute 'transaction' on 'IDBDatabase': The storeNames parameter was empty.") };
> 
> Can this case happen?

database.transaction([]) ?
Comment 4 Chris Dumez 2016-10-25 15:04:45 PDT 
Comment on attachment 292804 [details]
Patch

Clearing flags on attachment: 292804

Committed r207847: <http://trac.webkit.org/changeset/207847>
Comment 5 Chris Dumez 2016-10-25 15:04:50 PDT 
All reviewed patches have been landed.  Closing bug.