RESOLVED FIXED 163966
IDBDatabase.transaction() should take a union in parameter 
https://bugs.webkit.org/show_bug.cgi?id=163966
Summary IDBDatabase.transaction() should take a union in parameter
Chris Dumez
Reported 2016-10-25 12:39:42 PDT
IDBDatabase.transaction() should take a union in parameter: - https://www.w3.org/TR/IndexedDB/#widl-IDBDatabase-transaction-IDBTransaction-DOMString-sequence-DOMString--storeNames-IDBTransactionMode-mode
Attachments
Patch (5.19 KB, patch)
2016-10-25 13:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-10-25 13:06:12 PDT
Created attachment 292804 [details] Patch
Sam Weinig
Comment 2 2016-10-25 14:41:42 PDT
Comment on attachment 292804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292804&action=review > Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:179 > if (objectStores.isEmpty()) > return Exception { IDBDatabaseException::InvalidAccessError, ASCIILiteral("Failed to execute 'transaction' on 'IDBDatabase': The storeNames parameter was empty.") }; Can this case happen?
Chris Dumez
Comment 3 2016-10-25 14:43:40 PDT
Comment on attachment 292804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292804&action=review >> Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:179 >> return Exception { IDBDatabaseException::InvalidAccessError, ASCIILiteral("Failed to execute 'transaction' on 'IDBDatabase': The storeNames parameter was empty.") }; > > Can this case happen? database.transaction([]) ?
Chris Dumez
Comment 4 2016-10-25 15:04:45 PDT
Comment on attachment 292804 [details] Patch Clearing flags on attachment: 292804 Committed r207847: <http://trac.webkit.org/changeset/207847>
Chris Dumez
Comment 5 2016-10-25 15:04:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.