Bug 163954 - IndexedDB 2.0: Support IDBObjectStore openKeyCursor
Summary: IndexedDB 2.0: Support IDBObjectStore openKeyCursor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks: 160306
  Show dependency tree / graph
 
Reported: 2016-10-25 10:23 PDT by Brady Eidson
Modified: 2016-10-25 14:46 PDT (History)
7 users (show)

See Also:

Attachments
Patch (24.25 KB, patch)
2016-10-25 13:34 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (24.19 KB, patch)
2016-10-25 13:40 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (24.02 KB, patch)
2016-10-25 13:40 PDT, Brady Eidson 		aestes: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-10-25 10:23:11 PDT 
IndexedDB 2.0: Support IDBObjectStore openKeyCursor
Comment 1 Brady Eidson 2016-10-25 10:23:33 PDT 
<rdar://problem/28806930>
Comment 2 Brady Eidson 2016-10-25 13:34:55 PDT 
Created attachment 292810 [details]
Patch
Comment 3 Brady Eidson 2016-10-25 13:40:14 PDT 
Created attachment 292812 [details]
Patch
Comment 4 Brady Eidson 2016-10-25 13:40:51 PDT 
Created attachment 292813 [details]
Patch
Comment 5 Andy Estes 2016-10-25 13:49:44 PDT 
Comment on attachment 292812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292812&action=review

> Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:168
> -    auto info = IDBCursorInfo::objectStoreCursor(m_transaction.get(), m_info.identifier(), range, direction.value());
> +    auto info = IDBCursorInfo::objectStoreCursor(m_transaction.get(), m_info.identifier(), range.get(), direction.value(), IndexedDB::CursorType::KeyAndValue);

I was confused by the implicit conversion from a IDBKeyRange* to a IDBKeyRangeData. Since IDBCursorInfo::objectStoreCursor() is always passed a IDBKeyRangeData temporary, maybe this range can be moved into its destination IDBCursorInfo? Not something you have to change here, but just a thought.
Comment 6 Brady Eidson 2016-10-25 14:46:02 PDT 
https://trac.webkit.org/changeset/207845