Bug 163952 - [MediaStream] Add "has capture device" bit to media state flags
Summary: [MediaStream] Add "has capture device" bit to media state flags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on: 163965
Blocks:
  Show dependency tree / graph
 
Reported: 2016-10-25 10:18 PDT by Eric Carlson
Modified: 2016-10-26 08:12 PDT (History)
6 users (show)

See Also:

Attachments
Proposed patch. (12.99 KB, patch)
2016-10-25 10:24 PDT, Eric Carlson 		jer.noble: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2016-10-25 10:18:37 PDT 
Add "has active capture device" bit to media state flags
Comment 1 Eric Carlson 2016-10-25 10:24:17 PDT 
Created attachment 292773 [details]
Proposed patch.
Comment 2 Eric Carlson 2016-10-25 10:40:33 PDT 
Committed r207827: https://trac.webkit.org/r207827
Comment 3 Eric Carlson 2016-10-25 11:04:55 PDT 
Plus https://trac.webkit.org/r207828 to define the WK2 flag.
Comment 4 Ryan Haddad 2016-10-25 12:17:10 PDT 
The test added with this change is timing out on Mac WK1/WK2. WK1 has a repeated error in the result:

FAIL window.internals.isPagePlayingAudio() should be false. Threw exception TypeError: window.internals.isPagePlayingAudio is not a function. (In 'window.internals.isPagePlayingAudio()', 'window.internals.isPagePlayingAudio' is undefined)

https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/919
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/990
Comment 5 Ryan Haddad 2016-10-25 12:18:23 PDT 
(In reply to comment #4)
> The test added with this change is timing out on Mac WK1/WK2. WK1 has a
> repeated error in the result:
> 
> FAIL window.internals.isPagePlayingAudio() should be false. Threw exception
> TypeError: window.internals.isPagePlayingAudio is not a function. (In
> 'window.internals.isPagePlayingAudio()',
> 'window.internals.isPagePlayingAudio' is undefined)
> 
> https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/
> builds/919
> https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/
> builds/990

Correction, webaudio/web-audio-is-playing.html is an existing test that is now failing.
Comment 6 WebKit Commit Bot 2016-10-25 12:37:10 PDT 
Re-opened since this is blocked by bug 163965
Comment 7 Eric Carlson 2016-10-25 13:11:12 PDT 
Recommitted r207838: in https://trac.webkit.org/r207838
Comment 8 Eric Carlson 2016-10-25 13:13:01 PDT 
Correction: relanded as r207839: https://trac.webkit.org/207839
Comment 9 Eric Carlson 2016-10-26 08:12:39 PDT 
Plus r207898: https://trac.webkit.org/r207898