Bug 16395 – Inspector needs to use cached resources

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Gavin Sherlock]

Go to:

http://gcep.stanford.edu/

Inspect the page.  Note the image generated by:

http://cgi.stanford.edu/group/gcep/cgi-bin/random_image.cgi?path=images/home/rotating

The version showing on the page will be different than the image show in the web inspector - thus, the web inspector must re-interrogate that url instead of using the already rendered image.

[Timothy Hatcher]

Yep, we need to sue the cached version and not re-fetch the image.

[Alexander Pavlov (apavlov)]

*** Bug 47982 has been marked as a duplicate of this bug. ***

[Andrey Kosyakov]

Created attachment 71291 [details]
patch

- Added base64Encoded parameter to resourceContent() in Inspector.idl
- Cache resource content in resource.getContent()
- Report whether content is encoded along with content in callback
- Handle resource.getContent() properly if content is not yet available
- Use data: url for images if resource content is available

[Andrey Kosyakov]

Created attachment 71405 [details]
patch

- Fixed an attempt to retrieve content before it's available
- Dropped an accidental change to Settings.js

[Yury Semikhatsky]

Comment on attachment 71405 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71405&action=review

> WebCore/inspector/front-end/Resource.js:621
> +        if (typeof this._contentEncoded !== "undefined")

May be just use a separate flag _contetRequested?

> WebCore/inspector/front-end/Resource.js:635
> +        if (this.frameID) {

style: please remove the brackets

[Pavel Feldman]

Comment on attachment 71405 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71405&action=review

> WebCore/inspector/front-end/Resource.js:615
> +        return "data:" + this.mimeType + (this._contentEncoded ? ";base64," : ",") + this._content;

Could you please make sure it does not regress performance prior to landing? Opening slashdot / techcrunch and looking at the speed the icons show up with would be a good test.

[Andrey Kosyakov]

Created attachment 71867 [details]
patch to land

- rebased
- picked nits
- put usage of data url in resource tree thumbnails under flag (enabled by default)

[Andrey Kosyakov]

(In reply to comment #6)
> (From update of attachment 71405 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71405&action=review
> 
> > WebCore/inspector/front-end/Resource.js:615
> > +        return "data:" + this.mimeType + (this._contentEncoded ? ";base64," : ",") + this._content;
> 
> Could you please make sure it does not regress performance prior to landing? Opening slashdot / techcrunch and looking at the speed the icons show up with would be a good test.

There was no visual slow-down on techcrunch (with ~120 images, the average latency was ca. 500ms, 900ms worst; remote debugging mode slower by factor of ~1.3).

As discussed, putting usage of data urls in resource tree thumbnails under a flag (useDataURLForResourceImageIcons).

[Andrey Kosyakov]

Manually committed r70519: http://trac.webkit.org/changeset/70519