163947 – HeapTimer should not hardcode all of its subclasses and USE(CF) shouldn't be a bizarre special case

RESOLVED FIXED 163947

HeapTimer should not hardcode all of its subclasses and USE(CF) shouldn't be a bizarre special case

https://bugs.webkit.org/show_bug.cgi?id=163947

Summary HeapTimer should not hardcode all of its subclasses and USE(CF) shouldn't be ...

Filip Pizlo

Reported 2016-10-25 08:59:39 PDT

Patch forthcoming.

Attachments
the patch (18.19 KB, patch) 2016-10-25 09:56 PDT, Filip Pizlo	ggaren: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.15 MB, application/zip) 2016-10-25 11:06 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-yosemite (1.34 MB, application/zip) 2016-10-25 11:10 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-yosemite (485.81 KB, application/zip) 2016-10-25 11:15 PDT, Build Bot	no flags	Details
this might work (21.79 KB, patch) 2016-10-25 13:21 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (21.20 KB, patch) 2016-10-25 13:28 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
more (21.17 KB, patch) 2016-10-25 14:30 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (21.20 KB, patch) 2016-10-25 14:36 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
trying to get things to build (21.85 KB, patch) 2016-10-25 14:49 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
more fixes (21.91 KB, patch) 2016-10-25 15:22 PDT, Filip Pizlo	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2016-10-25 09:56:27 PDT

Created attachment 292766 [details] the patch

Geoffrey Garen

Comment 2 2016-10-25 09:58:09 PDT

Comment on attachment 292766 [details] the patch r=me

Build Bot

Comment 3 2016-10-25 11:06:05 PDT

Comment on attachment 292766 [details] the patch Attachment 292766 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2368784 Number of test failures exceeded the failure limit.

Build Bot

Comment 4 2016-10-25 11:06:10 PDT

Created attachment 292783 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-10-25 11:10:29 PDT

Comment on attachment 292766 [details] the patch Attachment 292766 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2368792 Number of test failures exceeded the failure limit.

Build Bot

Comment 6 2016-10-25 11:10:33 PDT

Created attachment 292785 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-10-25 11:15:05 PDT

Comment on attachment 292766 [details] the patch Attachment 292766 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2368833 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2016-10-25 11:15:09 PDT

Created attachment 292788 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Filip Pizlo

Comment 9 2016-10-25 13:21:53 PDT

Created attachment 292805 [details] this might work

Filip Pizlo

Comment 10 2016-10-25 13:28:16 PDT

Created attachment 292807 [details] the patch

Filip Pizlo

Comment 11 2016-10-25 13:28:44 PDT

Comment on attachment 292807 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=292807&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:249 > -@property (nonatomic, setter=_setFullscreenDelegate:) id<_WKFullscreenDelegate> _fullscreenDelegate WK_API_AVAILABLE(macos(10.13)); > -@property (nonatomic, readonly) BOOL _isInFullscreen WK_API_AVAILABLE(macos(WK_MAC_TBA)); > +@property (nonatomic, setter=_setFullscreenDelegate:) id<_WKFullscreenDelegate> _fullscreenDelegate WK_API_AVAILABLE(macosx(10.13)); > +@property (nonatomic, readonly) BOOL _isInFullscreen WK_API_AVAILABLE(macosx(WK_MAC_TBA)); I'll revert this or land it separately.

Filip Pizlo

Comment 12 2016-10-25 13:37:49 PDT

Comment on attachment 292807 [details] the patch I'll wait with r? until I get it to actually work.

Filip Pizlo

Comment 13 2016-10-25 14:30:37 PDT

Created attachment 292821 [details] more

Filip Pizlo

Comment 14 2016-10-25 14:32:02 PDT

Comment on attachment 292821 [details] more View in context: https://bugs.webkit.org/attachment.cgi?id=292821&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:249 > -@property (nonatomic, setter=_setFullscreenDelegate:) id<_WKFullscreenDelegate> _fullscreenDelegate WK_API_AVAILABLE(macos(10.13)); > -@property (nonatomic, readonly) BOOL _isInFullscreen WK_API_AVAILABLE(macos(WK_MAC_TBA)); > +@property (nonatomic, setter=_setFullscreenDelegate:) id<_WKFullscreenDelegate> _fullscreenDelegate WK_API_AVAILABLE(macosx(10.13)); > +@property (nonatomic, readonly) BOOL _isInFullscreen WK_API_AVAILABLE(macosx(WK_MAC_TBA)); I'll revert this or land separately. I need it to build right now.

Filip Pizlo

Comment 15 2016-10-25 14:36:56 PDT

Created attachment 292822 [details] the patch

Filip Pizlo

Comment 16 2016-10-25 14:49:35 PDT

Created attachment 292825 [details] trying to get things to build

Filip Pizlo

Comment 17 2016-10-25 15:22:02 PDT

Created attachment 292832 [details] more fixes

Filip Pizlo

Comment 18 2016-10-25 16:13:48 PDT

Comment on attachment 292832 [details] more fixes View in context: https://bugs.webkit.org/attachment.cgi?id=292832&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:249 > -@property (nonatomic, setter=_setFullscreenDelegate:) id<_WKFullscreenDelegate> _fullscreenDelegate WK_API_AVAILABLE(macos(10.13)); > -@property (nonatomic, readonly) BOOL _isInFullscreen WK_API_AVAILABLE(macos(WK_MAC_TBA)); > +@property (nonatomic, setter=_setFullscreenDelegate:) id<_WKFullscreenDelegate> _fullscreenDelegate WK_API_AVAILABLE(macosx(10.13)); > +@property (nonatomic, readonly) BOOL _isInFullscreen WK_API_AVAILABLE(macosx(WK_MAC_TBA)); I'll either revert or land separately. I needed this to build.

Geoffrey Garen

Comment 19 2016-10-25 16:20:54 PDT

Comment on attachment 292832 [details] more fixes r=me

Filip Pizlo

Comment 20 2016-10-25 16:26:00 PDT

Landed in https://trac.webkit.org/changeset/207855

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware All

OS All

Product WebKit

Component JavaScriptCore

Assignee

Filip Pizlo

Reported

2016-10-25 08:59 PDT

Modified

2016-10-25 16:26 PDT History

CC List

7 users Show

URL

Keywords

Depends on

Blocks

163562

Dependencies

tree graph