Bug 163945 - [cmake] Check if jscLib and WebKitGUID targets exist before using them
Summary: [cmake] Check if jscLib and WebKitGUID targets exist before using them
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-25 08:23 PDT by Konstantin Tokarev
Modified: 2016-10-25 12:17 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.57 KB, patch)
2016-10-25 08:29 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-10-25 08:23:19 PDT 
Currently these targets are used under WIN32 condition, however they are defined in PlatformWin.cmake, causing CMake warnings if port supports WIN32 but does not use PlatformWin.cmake
Comment 1 Konstantin Tokarev 2016-10-25 08:29:04 PDT 
Created attachment 292753 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-25 12:17:46 PDT 
Comment on attachment 292753 [details]
Patch

Clearing flags on attachment: 292753

Committed r207831: <http://trac.webkit.org/changeset/207831>
Comment 3 WebKit Commit Bot 2016-10-25 12:17:50 PDT 
All reviewed patches have been landed.  Closing bug.