Bug 163935 - IDBObjectStore.createIndex() should take a union in parameter
Summary: IDBObjectStore.createIndex() should take a union in parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://www.w3.org/TR/IndexedDB/#idl-...
Keywords:
Depends on:
Blocks: 163909
  Show dependency tree / graph
 
Reported: 2016-10-24 22:48 PDT by Chris Dumez
Modified: 2016-10-25 12:20 PDT (History)
8 users (show)

See Also:

Attachments
WIP patch (9.55 KB, patch)
2016-10-24 22:49 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (10.30 KB, patch)
2016-10-25 09:57 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-24 22:48:08 PDT 
IDBObjectStore.createIndex() should take a union in parameter:
- https://www.w3.org/TR/IndexedDB/#idl-def-IDBObjectStore
Comment 1 Chris Dumez 2016-10-24 22:49:33 PDT 
Created attachment 292722 [details]
WIP patch
Comment 2 WebKit Commit Bot 2016-10-24 22:51:30 PDT 
Attachment 292722 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/IDBObjectStore.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2016-10-25 09:57:39 PDT 
Created attachment 292767 [details]
Patch
Comment 4 Darin Adler 2016-10-25 11:07:06 PDT 
Comment on attachment 292767 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292767&action=review

> Source/WebCore/Modules/indexeddb/IDBKeyPath.h:37
> +bool isIDBKeyPathValid(const IDBKeyPathVariant&);

OK, maybe we won’t be getting rid of this header.
Comment 5 WebKit Commit Bot 2016-10-25 12:20:27 PDT 
Comment on attachment 292767 [details]
Patch

Clearing flags on attachment: 292767

Committed r207832: <http://trac.webkit.org/changeset/207832>
Comment 6 WebKit Commit Bot 2016-10-25 12:20:33 PDT 
All reviewed patches have been landed.  Closing bug.